Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 275673003: Revert 269075 "Revert 268939 "Pass RenderFrameHost to WebContent..." (Closed)

Created:
6 years, 7 months ago by rpetterson
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 269075 "Revert 268939 "Pass RenderFrameHost to WebContent..." > Revert 268939 "Pass RenderFrameHost to WebContentObservers' mess..." > > Win and linux bots are failing. See crbug.com/371030 for more details. > Reverting to see if this CL is part of the cause. > > > Pass RenderFrameHost to WebContentObservers' message handlers > > > > This patch enables WebContentsObserver::OnMessageReceived to receive > > a reference to RenderFrameHost that received the message. > > > > This allows passing of JavaBridgeDispatcherHostManager ownership from > > WebContentsImpl to ContentViewCore and removing of some redundant > > initialization code in JavaBridgeDispatcherHostManager, fixing > > a long-standing TODO. > > > > Review URL: https://codereview.chromium.org/253013002 > > TBR=mnaganov@chromium.org > > Review URL: https://codereview.chromium.org/271863005 TBR=rlp@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -109 lines) Patch
M trunk/src/chrome/browser/content_settings/tab_specific_content_settings.h View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/guest_view/web_view/plugin_permission_helper.h View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/guest_view/web_view/plugin_permission_helper.cc View 1 chunk +15 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/plugins/plugin_observer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/plugins/plugin_observer.cc View 2 chunks +14 lines, -3 lines 0 comments Download
M trunk/src/content/browser/android/content_view_core_impl.h View 4 chunks +8 lines, -3 lines 0 comments Download
M trunk/src/content/browser/android/content_view_core_impl.cc View 5 chunks +25 lines, -23 lines 0 comments Download
M trunk/src/content/browser/frame_host/interstitial_page_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/content/browser/frame_host/interstitial_page_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M trunk/src/content/browser/renderer_host/java/java_bridge_dispatcher_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.h View 3 chunks +10 lines, -12 lines 0 comments Download
M trunk/src/content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.cc View 5 chunks +25 lines, -27 lines 0 comments Download
M trunk/src/content/browser/web_contents/web_contents_impl.h View 4 chunks +0 lines, -13 lines 0 comments Download
M trunk/src/content/browser/web_contents/web_contents_impl.cc View 5 chunks +9 lines, -14 lines 0 comments Download
M trunk/src/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 4 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/content/public/browser/web_contents_observer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/content/public/browser/web_contents_observer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M trunk/src/extensions/browser/extension_function.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rpetterson
6 years, 7 months ago (2014-05-09 00:44:44 UTC) #1
mnaganov (inactive)
The CQ bit was checked by mnaganov@chromium.org
6 years, 7 months ago (2014-05-09 12:00:26 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 12:05:28 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 7 months ago (2014-05-09 12:05:29 UTC) #4
mnaganov (inactive)
On 2014/05/09 12:05:29, I haz the power (commit-bot) wrote: > Commit queue rejected this change ...
6 years, 7 months ago (2014-05-09 12:46:05 UTC) #5
rpetterson
6 years, 7 months ago (2014-05-09 16:54:11 UTC) #6
Cool, thanks.


On Fri, May 9, 2014 at 5:46 AM, <mnaganov@chromium.org> wrote:

> On 2014/05/09 12:05:29, I haz the power (commit-bot) wrote:
>
>> Commit queue rejected this change because it did not recognize the base
>> URL.
>> Please commit your change manually.
>>
>
> Created a better version here: https://codereview.chromium.org/275873002/
> Will close this one.
>
> https://codereview.chromium.org/275673003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698