Revert 268939 "Pass RenderFrameHost to WebContentObservers' mess..."

Revert 268939 "Pass RenderFrameHost to WebContentObservers' mess..."

Win and linux bots are failing. See crbug.com/371030 for more details.
Reverting to see if this CL is part of the cause.

> Pass RenderFrameHost to WebContentObservers' message handlers
> 
> This patch enables WebContentsObserver::OnMessageReceived to receive
> a reference to RenderFrameHost that received the message.
> 
> This allows passing of JavaBridgeDispatcherHostManager ownership from
> WebContentsImpl to ContentViewCore and removing of some redundant
> initialization code in JavaBridgeDispatcherHostManager, fixing
> a long-standing TODO.
> 
> Review URL: https://codereview.chromium.org/253013002

TBR=mnaganov@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269075

[rpetterson, 2014-05-08 18:23:24]

Committed patchset #1 manually as r269075 (tree was closed).

[mnaganov (inactive), 2014-05-08 21:26:49]

On 2014/05/08 18:23:24, rpetterson wrote:
> Committed patchset #1 manually as r269075 (tree was closed).

Looks like the tests still fail even after the revert:
http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%282%29/bui...

Are you planning to revert the reverts after fixing the real cause?

[rpetterson, 2014-05-08 21:40:51]

I can revert the revert after the tree goes green again.


On Thu, May 8, 2014 at 2:26 PM, <mnaganov@chromium.org> wrote:

> On 2014/05/08 18:23:24, rpetterson wrote:
>
>> Committed patchset #1 manually as r269075 (tree was closed).
>>
>
> Looks like the tests still fail even after the revert:
> http://build.chromium.org/p/chromium.win/builders/Vista%
> 20Tests%20%282%29/builds/42536
>
> Are you planning to revert the reverts after fixing the real cause?
>
> https://codereview.chromium.org/271863005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[rpetterson, 2014-05-09 00:46:40]

I have reverted the revert and thereby un-reverted.


On Thu, May 8, 2014 at 2:40 PM, Rachel Weinstein Petterson <rlp@chromium.org
> wrote:

> I can revert the revert after the tree goes green again.
>
>
> On Thu, May 8, 2014 at 2:26 PM, <mnaganov@chromium.org> wrote:
>
>> On 2014/05/08 18:23:24, rpetterson wrote:
>>
>>> Committed patchset #1 manually as r269075 (tree was closed).
>>>
>>
>> Looks like the tests still fail even after the revert:
>> http://build.chromium.org/p/chromium.win/builders/Vista%
>> 20Tests%20%282%29/builds/42536
>>
>> Are you planning to revert the reverts after fixing the real cause?
>>
>> https://codereview.chromium.org/271863005/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mnaganov (inactive), 2014-05-09 08:50:35]

Hi Rachel,

Do you have a link to the CL for reverting the revert? I don't see it
landed yet.


On Fri, May 9, 2014 at 1:46 AM, Rachel Weinstein Petterson <rlp@chromium.org
> wrote:

> I have reverted the revert and thereby un-reverted.
>
>
> On Thu, May 8, 2014 at 2:40 PM, Rachel Weinstein Petterson <
> rlp@chromium.org> wrote:
>
>> I can revert the revert after the tree goes green again.
>>
>>
>> On Thu, May 8, 2014 at 2:26 PM, <mnaganov@chromium.org> wrote:
>>
>>> On 2014/05/08 18:23:24, rpetterson wrote:
>>>
>>>> Committed patchset #1 manually as r269075 (tree was closed).
>>>>
>>>
>>> Looks like the tests still fail even after the revert:
>>> http://build.chromium.org/p/chromium.win/builders/Vista%
>>> 20Tests%20%282%29/builds/42536
>>>
>>> Are you planning to revert the reverts after fixing the real cause?
>>>
>>> https://codereview.chromium.org/271863005/
>>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mnaganov (inactive), 2014-05-09 12:02:46]

OK, found it: https://codereview.chromium.org/275673003/


On Fri, May 9, 2014 at 9:50 AM, Mikhail Naganov <mnaganov@chromium.org>wrote:

> Hi Rachel,
>
> Do you have a link to the CL for reverting the revert? I don't see it
> landed yet.
>
>
> On Fri, May 9, 2014 at 1:46 AM, Rachel Weinstein Petterson <
> rlp@chromium.org> wrote:
>
>> I have reverted the revert and thereby un-reverted.
>>
>>
>> On Thu, May 8, 2014 at 2:40 PM, Rachel Weinstein Petterson <
>> rlp@chromium.org> wrote:
>>
>>> I can revert the revert after the tree goes green again.
>>>
>>>
>>> On Thu, May 8, 2014 at 2:26 PM, <mnaganov@chromium.org> wrote:
>>>
>>>> On 2014/05/08 18:23:24, rpetterson wrote:
>>>>
>>>>> Committed patchset #1 manually as r269075 (tree was closed).
>>>>>
>>>>
>>>> Looks like the tests still fail even after the revert:
>>>> http://build.chromium.org/p/chromium.win/builders/Vista%
>>>> 20Tests%20%282%29/builds/42536
>>>>
>>>> Are you planning to revert the reverts after fixing the real cause?
>>>>
>>>> https://codereview.chromium.org/271863005/
>>>>
>>>
>>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[marja, 2014-05-09 12:09:55]

(Feel free to reland (or revert the revert), and sorry for unnecessary
reverts. Yesterday was pretty disastrous.)


On Fri, May 9, 2014 at 2:02 PM, Mikhail Naganov <mnaganov@chromium.org>wrote:

> OK, found it: https://codereview.chromium.org/275673003/
>
>
> On Fri, May 9, 2014 at 9:50 AM, Mikhail Naganov <mnaganov@chromium.org>wrote:
>
>> Hi Rachel,
>>
>> Do you have a link to the CL for reverting the revert? I don't see it
>> landed yet.
>>
>>
>> On Fri, May 9, 2014 at 1:46 AM, Rachel Weinstein Petterson <
>> rlp@chromium.org> wrote:
>>
>>> I have reverted the revert and thereby un-reverted.
>>>
>>>
>>> On Thu, May 8, 2014 at 2:40 PM, Rachel Weinstein Petterson <
>>> rlp@chromium.org> wrote:
>>>
>>>> I can revert the revert after the tree goes green again.
>>>>
>>>>
>>>> On Thu, May 8, 2014 at 2:26 PM, <mnaganov@chromium.org> wrote:
>>>>
>>>>> On 2014/05/08 18:23:24, rpetterson wrote:
>>>>>
>>>>>> Committed patchset #1 manually as r269075 (tree was closed).
>>>>>>
>>>>>
>>>>> Looks like the tests still fail even after the revert:
>>>>> http://build.chromium.org/p/chromium.win/builders/Vista%
>>>>> 20Tests%20%282%29/builds/42536
>>>>>
>>>>> Are you planning to revert the reverts after fixing the real cause?
>>>>>
>>>>> https://codereview.chromium.org/271863005/
>>>>>
>>>>
>>>>
>>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mnaganov (inactive), 2014-05-09 12:15:05]

No troubles! As the revert of the revert uses incorrect base path, it can't
be landed by CQ. So I will create my own patch instead. Thanks for
addressing the tree fire issue!


On Fri, May 9, 2014 at 1:09 PM, Marja Hölttä <marja@chromium.org> wrote:

> (Feel free to reland (or revert the revert), and sorry for unnecessary
> reverts. Yesterday was pretty disastrous.)
>
>
> On Fri, May 9, 2014 at 2:02 PM, Mikhail Naganov <mnaganov@chromium.org>wrote:
>
>> OK, found it: https://codereview.chromium.org/275673003/
>>
>>
>> On Fri, May 9, 2014 at 9:50 AM, Mikhail Naganov
<mnaganov@chromium.org>wrote:
>>
>>> Hi Rachel,
>>>
>>> Do you have a link to the CL for reverting the revert? I don't see it
>>> landed yet.
>>>
>>>
>>> On Fri, May 9, 2014 at 1:46 AM, Rachel Weinstein Petterson <
>>> rlp@chromium.org> wrote:
>>>
>>>> I have reverted the revert and thereby un-reverted.
>>>>
>>>>
>>>> On Thu, May 8, 2014 at 2:40 PM, Rachel Weinstein Petterson <
>>>> rlp@chromium.org> wrote:
>>>>
>>>>> I can revert the revert after the tree goes green again.
>>>>>
>>>>>
>>>>> On Thu, May 8, 2014 at 2:26 PM, <mnaganov@chromium.org> wrote:
>>>>>
>>>>>> On 2014/05/08 18:23:24, rpetterson wrote:
>>>>>>
>>>>>>> Committed patchset #1 manually as r269075 (tree was closed).
>>>>>>>
>>>>>>
>>>>>> Looks like the tests still fail even after the revert:
>>>>>> http://build.chromium.org/p/chromium.win/builders/Vista%
>>>>>> 20Tests%20%282%29/builds/42536
>>>>>>
>>>>>> Are you planning to revert the reverts after fixing the real cause?
>>>>>>
>>>>>> https://codereview.chromium.org/271863005/
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.