Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2756723003: Avoid using the method pointer to Callback::Run in ServiceWorkerVersion (Closed)

Created:
3 years, 9 months ago by tzik
Modified:
3 years, 9 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid using the method pointer to Callback::Run in ServiceWorkerVersion This CL removes a problematic method pointer to Callback::Run from ServiceWorkerVersion code. The method pointer prevents it from overloading or templatize, and its removal makes Callback implementation simple and consistent. Review-Url: https://codereview.chromium.org/2756723003 Cr-Commit-Position: refs/heads/master@{#458334} Committed: https://chromium.googlesource.com/chromium/src/+/14d44e70cf6e529d5cd1ae82364c2ce7ec444ae9

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M content/browser/service_worker/service_worker_version.h View 4 chunks +19 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (13 generated)
tzik
PTAL
3 years, 9 months ago (2017-03-17 14:09:12 UTC) #5
nhiroki
lgtm
3 years, 9 months ago (2017-03-21 05:56:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756723003/20001
3 years, 9 months ago (2017-03-21 06:58:55 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 07:06:09 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/14d44e70cf6e529d5cd1ae82364c...

Powered by Google App Engine
This is Rietveld 408576698