Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Issue 2756683002: Fix RenderTextMac. (Closed)

Created:
3 years, 9 months ago by snake
Modified:
3 years, 9 months ago
Reviewers:
tapted, msw
CC:
chromium-reviews, mac-reviews_chromium.org, Alexei Svitkine (slow)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix text rendering with RenderTextMac. BUG=606705 Glyph 65535 means that the glyph is not printable. Replacing it with 0 results in a striped glyph that's rendered instead of non-printable glyphs. Just remove old invalid code to fix this. In my testing no Skia asserts were triggered. Without this fix the title in tab of url : https://www.google.ru/trends/yis/2016/RU?autoplay=1 will be incorrect rendered: See https://bugs.chromium.org/p/chromium/issues/detail?id=606705#c4 Review-Url: https://codereview.chromium.org/2756683002 Cr-Commit-Position: refs/heads/master@{#457472} Committed: https://chromium.googlesource.com/chromium/src/+/76ea7030842aa09fbe9675701d7a879243ada736

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M ui/gfx/render_text_mac.mm View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
snake
3 years, 9 months ago (2017-03-16 13:56:05 UTC) #3
msw
Did you test the arabic case cited too? If so, lgtm. +CC asvitkine@ as code ...
3 years, 9 months ago (2017-03-16 17:04:52 UTC) #8
snake
On 2017/03/16 17:04:52, msw wrote: > Did you test the arabic case cited too? If ...
3 years, 9 months ago (2017-03-16 17:15:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756683002/1
3 years, 9 months ago (2017-03-16 17:15:45 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 17:25:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/76ea7030842aa09fbe9675701d7a...

Powered by Google App Engine
This is Rietveld 408576698