Implement stack trace printing callback for v8

Implement stack trace printing callback for v8

BUG=none
R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2756673004
Cr-Commit-Position: refs/heads/master@{#458029}
Committed: https://chromium.googlesource.com/chromium/src/+/4844f72ece1a4a870e571e8e53746bd4c7d3f6f6

[jochen (gone - plz use gerrit), 2017-03-17 11:45:57]

ptal

depends on https://chromium-review.googlesource.com/c/456338/

[Yang, 2017-03-17 11:51:34]

On 2017/03/17 11:45:57, jochen wrote:
> ptal
> 
> depends on https://chromium-review.googlesource.com/c/456338/

LGTM, but I'm not actually a Chromium committer :P

[jochen (gone - plz use gerrit), 2017-03-17 13:10:01]

jochen@chromium.org changed reviewers:
+ marja@chromium.org

[jochen (gone - plz use gerrit), 2017-03-17 13:10:02]

+marja ptal

[marja, 2017-03-17 13:15:09]

If I understand correctly, you're going to remove the StackTrace in v8 and let
the embedder provide stack trace printing functionality.

One thing which is no longer possible with this approach is storing a stack
trace and printing it later (under some condition). But it should be possible to
work around that limitation when debugging locally...

I.e., lgtm, assuming that trade off makes sense to you.

[jochen (gone - plz use gerrit), 2017-03-17 13:17:29]

On 2017/03/17 at 13:15:09, marja wrote:
> If I understand correctly, you're going to remove the StackTrace in v8 and let
the embedder provide stack trace printing functionality.
> 
> One thing which is no longer possible with this approach is storing a stack
trace and printing it later (under some condition). But it should be possible to
work around that limitation when debugging locally...

why would that not be possible?

> 
> I.e., lgtm, assuming that trade off makes sense to you.

[jochen (gone - plz use gerrit), 2017-03-20 08:04:38]

(I clarified offline that the v8 stack trace code is not being removed, but the
embedder can provide its own stack trace printer in addition)

[jochen (gone - plz use gerrit), 2017-03-20 08:04:42]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 08:04:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2017-03-20 08:24:33]

The CQ bit was unchecked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2017-03-20 08:24:35]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2017-03-20 08:24:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 09:07:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489998275821440, "parent_rev":
"33ac37fdb8da49817a14b12205afa06d928476cb", "commit_rev":
"4844f72ece1a4a870e571e8e53746bd4c7d3f6f6"}

[commit-bot: I haz the power, 2017-03-20 09:07:44]

Description was changed from

==========
Implement stack trace printing callback for v8

BUG=none
R=yangguo@chromium.org
==========

to

==========
Implement stack trace printing callback for v8

BUG=none
R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2756673004
Cr-Commit-Position: refs/heads/master@{#458029}
Committed:
https://chromium.googlesource.com/chromium/src/+/4844f72ece1a4a870e571e8e5374...
==========

[commit-bot: I haz the power, 2017-03-20 09:07:47]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4844f72ece1a4a870e571e8e5374...