Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2756673003: arc: Update device owner check implementation (Closed)

Created:
3 years, 9 months ago by abhishekbh
Modified:
3 years, 9 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, cbentzel+watch_chromium.org, yusukes+watch_chromium.org, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, hidehiko+watch_chromium.org, sdefresne+watchlist_chromium.org, lhchavez+watch_chromium.org, abhishekbh_chromium.org, Kevin Cernekee, Sameer Nanda
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

arc: Update device owner check implementation Update the device owner check to compare the account id of the active user with the account id of the owner as provided by the user manager API. The old implementation uses the logged in user state API which for unbeknownst reasons returns the owner as a regular user. It can also change asynchronously at boot resulting in racy behavior as its used right now. BUG=702311 BUG=b:34661187 BUG=b:33488433 TEST=run cts -c android.net.wifi.cts.WifiEnterpriseConfigTest -m testAddEapNetwork TEST=run cts -c android.net.wifi.cts.WifiManagerTest -m testWifiManagerNetWork NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2756443003 Cr-Commit-Position: refs/heads/master@{#457563} (cherry picked from commit eb260ae77f464ec4b53627278b9e842cafb3490e) Review-Url: https://codereview.chromium.org/2756673003 Cr-Commit-Position: refs/branch-heads/2987@{#837} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/42857f2ed421f4b47ff68cca13ea9266016451cd

Patch Set 1 #

Patch Set 2 : Add CrBug number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M components/arc/net/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/arc/net/arc_net_host_impl.cc View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Luis Héctor Chávez
lgtm
3 years, 9 months ago (2017-03-16 23:10:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756673003/20001
3 years, 9 months ago (2017-03-16 23:16:43 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 9 months ago (2017-03-16 23:16:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756673003/20001
3 years, 9 months ago (2017-03-16 23:32:52 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 23:38:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/42857f2ed421f4b47ff68cca13ea...

Powered by Google App Engine
This is Rietveld 408576698