Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6230)

Unified Diff: components/image_fetcher/image_data_fetcher.cc

Issue 2756633003: [Image Fetcher] Add support to disable cookies (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/image_fetcher/image_data_fetcher.cc
diff --git a/components/image_fetcher/image_data_fetcher.cc b/components/image_fetcher/image_data_fetcher.cc
index 204fa95d7e80df557d859271fbe6674c3df7b2bc..b9604b7c66ca4efa47ad89b0a8e12f59223ae9ff 100644
--- a/components/image_fetcher/image_data_fetcher.cc
+++ b/components/image_fetcher/image_data_fetcher.cc
@@ -38,7 +38,8 @@ ImageDataFetcher::ImageDataFetcher(
net::URLRequestContextGetter* url_request_context_getter)
: url_request_context_getter_(url_request_context_getter),
data_use_service_name_(DataUseUserData::IMAGE_FETCHER_UNTAGGED),
- next_url_fetcher_id_(0) {}
+ next_url_fetcher_id_(0),
+ disable_cookies_(false) {}
markusheintz_ 2017/03/16 09:59:06 The default should be true. If we need a way to
ImageDataFetcher::~ImageDataFetcher() {}
@@ -47,6 +48,10 @@ void ImageDataFetcher::SetDataUseServiceName(
data_use_service_name_ = data_use_service_name;
}
+void ImageDataFetcher::DisableCookies() {
+ disable_cookies_ = true;
+}
+
void ImageDataFetcher::FetchImageData(
const GURL& image_url,
const ImageDataFetcherCallback& callback) {
@@ -70,6 +75,10 @@ void ImageDataFetcher::FetchImageData(
request->url_fetcher->SetRequestContext(url_request_context_getter_.get());
request->url_fetcher->SetReferrer(referrer);
request->url_fetcher->SetReferrerPolicy(referrer_policy);
+ if (disable_cookies_) {
markusheintz_ 2017/03/16 09:59:06 Not fetching cookies should be the default.
+ request->url_fetcher->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
+ net::LOAD_DO_NOT_SAVE_COOKIES);
+ }
request->url_fetcher->Start();
pending_requests_[request->url_fetcher.get()] = std::move(request);

Powered by Google App Engine
This is Rietveld 408576698