[Image Fetcher] Add support to disable cookies

components/image_fetcher/image_data_fetcher.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/image_fetcher/image_data_fetcher.h"
 
 #include "net/base/load_flags.h"
 #include "net/http/http_response_headers.h"
 #include "net/http/http_status_code.h"
 #include "net/url_request/url_fetcher.h"
@@ skipping 20 matching lines @@
   // be run even if the image data could not be fetched successfully.
   ImageDataFetcherCallback callback;
 
   std::unique_ptr<net::URLFetcher> url_fetcher;
 };
 
 ImageDataFetcher::ImageDataFetcher(
     net::URLRequestContextGetter* url_request_context_getter)
     : url_request_context_getter_(url_request_context_getter),
       data_use_service_name_(DataUseUserData::IMAGE_FETCHER_UNTAGGED),
-      next_url_fetcher_id_(0) {}
+      next_url_fetcher_id_(0),
+      disable_cookies_(false) {}

[markusheintz_, 2017/03/16 09:59:06]

The default should be true. 

If we need a way to enable cookies, we should have a EnableCookies method.

 
 ImageDataFetcher::~ImageDataFetcher() {}
 
 void ImageDataFetcher::SetDataUseServiceName(
     DataUseServiceName data_use_service_name) {
   data_use_service_name_ = data_use_service_name;
 }
 
+void ImageDataFetcher::DisableCookies() {
+  disable_cookies_ = true;
+}
+
 void ImageDataFetcher::FetchImageData(
     const GURL& image_url,
     const ImageDataFetcherCallback& callback) {
   FetchImageData(
       image_url, callback, /*referrer=*/std::string(),
       net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE);
 }
 
 void ImageDataFetcher::FetchImageData(
     const GURL& image_url,
     const ImageDataFetcherCallback& callback,
     const std::string& referrer,
     net::URLRequest::ReferrerPolicy referrer_policy) {
   std::unique_ptr<net::URLFetcher> url_fetcher = net::URLFetcher::Create(
       next_url_fetcher_id_++, image_url, net::URLFetcher::GET, this);
 
   DataUseUserData::AttachToFetcher(url_fetcher.get(), data_use_service_name_);
 
   std::unique_ptr<ImageDataFetcherRequest> request(
       new ImageDataFetcherRequest(callback, std::move(url_fetcher)));
   request->url_fetcher->SetRequestContext(url_request_context_getter_.get());
   request->url_fetcher->SetReferrer(referrer);
   request->url_fetcher->SetReferrerPolicy(referrer_policy);
+  if (disable_cookies_) {

[markusheintz_, 2017/03/16 09:59:06]

Not fetching cookies should be the default.

+    request->url_fetcher->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
+                                       net::LOAD_DO_NOT_SAVE_COOKIES);
+  }
   request->url_fetcher->Start();
 
   pending_requests_[request->url_fetcher.get()] = std::move(request);
 }
 
 void ImageDataFetcher::OnURLFetchComplete(const net::URLFetcher* source) {
   auto request_iter = pending_requests_.find(source);
   DCHECK(request_iter != pending_requests_.end());
 
   bool success = source->GetStatus().status() == net::URLRequestStatus::SUCCESS;
@@ skipping 10 matching lines @@
   if (success) {
     source->GetResponseAsString(&image_data);
   }
   request_iter->second->callback.Run(image_data, metadata);
 
   // Remove the finished request.
   pending_requests_.erase(request_iter);
 }
 
 }  // namespace image_fetcher