Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2756593004: Start unraveling circularities between analyzer and front_end/kernel. (Closed)

Created:
3 years, 9 months ago by Paul Berry
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Start unraveling circularities between analyzer and front_end/kernel. This CL moves many of the files from pkg/front_end/lib/src/fasta/analyzer/ to pkg/analyzer/lib/src/fasta/. It also moves two files from pkg/kernel/lib/analyzer/ to pkg/analyzer/lib/src/kernel/. This reduces the amount of circularity between analyzer and front_end/kernel so that there are no files in front_end or kernel which are both dependend upon by analyzer and depend upon analyzer. I will clean up the remaining circularities in future CLs. There should be no functional change. R=ahe@google.com, asgerf@google.com, kmillikin@google.com, scheglov@google.com, sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/685045d61976b72bbe94a58c1a19cdea8d638840

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -7600 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/analyzer/lib/src/fasta/analyzer.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/analyzer/lib/src/fasta/ast_builder.dart View 1 chunk +7 lines, -7 lines 0 comments Download
A + pkg/analyzer/lib/src/fasta/element_store.dart View 2 chunks +4 lines, -4 lines 0 comments Download
A + pkg/analyzer/lib/src/fasta/mock_element.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analyzer/lib/src/fasta/mock_type.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analyzer/lib/src/fasta/token_utils.dart View 2 chunks +9 lines, -9 lines 0 comments Download
A + pkg/analyzer/lib/src/kernel/ast_from_analyzer.dart View 1 chunk +10 lines, -8 lines 0 comments Download
A + pkg/analyzer/lib/src/kernel/loader.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/kernel_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/front_end/lib/src/fasta/analyzer/analyzer.dart View 1 chunk +0 lines, -38 lines 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/analyzer_diet_listener.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/analyzer_loader.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 1 chunk +0 lines, -1776 lines 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/compile_platform_dartk.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/front_end/lib/src/fasta/analyzer/element_store.dart View 1 chunk +0 lines, -299 lines 0 comments Download
D pkg/front_end/lib/src/fasta/analyzer/mock_element.dart View 1 chunk +0 lines, -375 lines 0 comments Download
D pkg/front_end/lib/src/fasta/analyzer/mock_type.dart View 1 chunk +0 lines, -162 lines 0 comments Download
D pkg/front_end/lib/src/fasta/analyzer/token_utils.dart View 1 chunk +0 lines, -791 lines 0 comments Download
M pkg/front_end/lib/src/fasta/testing/kernel_chain.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/testing/suite.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/incremental_kernel_generator_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/scanner_fasta_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/scanner_roundtrip_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/subpackage_relationships_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/front_end/tool/fasta_perf.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/kernel/bin/dartk.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/kernel/lib/analyzer/analyzer.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D pkg/kernel/lib/analyzer/ast_from_analyzer.dart View 1 chunk +0 lines, -3079 lines 0 comments Download
D pkg/kernel/lib/analyzer/loader.dart View 1 chunk +0 lines, -1004 lines 0 comments Download
M pkg/kernel/test/baseline_tester.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/kernel/test/closures/suite.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/kernel/test/frontend_bench.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/kernel/test/reify/suite.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Paul Berry
3 years, 9 months ago (2017-03-16 17:18:25 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 9 months ago (2017-03-16 17:23:36 UTC) #3
scheglov
LGTM
3 years, 9 months ago (2017-03-16 17:26:39 UTC) #4
ahe
LGTM, but I think you want to hear what Asger and Kevin thinks.
3 years, 9 months ago (2017-03-16 17:27:26 UTC) #6
asgerf
Also LGTM
3 years, 9 months ago (2017-03-17 10:12:12 UTC) #7
Kevin Millikin (Google)
LGTM, and thanks for starting this.
3 years, 9 months ago (2017-03-17 10:29:52 UTC) #8
ahe
\o/ :-D
3 years, 9 months ago (2017-03-17 11:06:15 UTC) #9
Paul Berry
3 years, 9 months ago (2017-03-17 12:56:14 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
685045d61976b72bbe94a58c1a19cdea8d638840 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698