Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: pkg/front_end/test/subpackage_relationships_test.dart

Issue 2756593004: Start unraveling circularities between analyzer and front_end/kernel. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/front_end/test/scanner_roundtrip_test.dart ('k') | pkg/front_end/tool/fasta_perf.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:async'; 5 import 'dart:async';
6 import 'dart:io'; 6 import 'dart:io';
7 7
8 import 'package:front_end/compiler_options.dart'; 8 import 'package:front_end/compiler_options.dart';
9 import 'package:front_end/dependency_grapher.dart'; 9 import 'package:front_end/dependency_grapher.dart';
10 import 'package:path/path.dart' as pathos; 10 import 'package:path/path.dart' as pathos;
(...skipping 26 matching lines...) Expand all
37 'lib/src/fasta/builder', 37 'lib/src/fasta/builder',
38 'lib/src/fasta/dill', 38 'lib/src/fasta/dill',
39 'lib/src/fasta/kernel', 39 'lib/src/fasta/kernel',
40 'lib/src/fasta/parser', 40 'lib/src/fasta/parser',
41 'lib/src/fasta/scanner', 41 'lib/src/fasta/scanner',
42 'lib/src/fasta/testing', 42 'lib/src/fasta/testing',
43 'lib/src/fasta/util', 43 'lib/src/fasta/util',
44 ]), 44 ]),
45 'lib/src/fasta/analyzer': 45 'lib/src/fasta/analyzer':
46 new SubpackageRules(mayImportAnalyzer: true, allowedDependencies: [ 46 new SubpackageRules(mayImportAnalyzer: true, allowedDependencies: [
47 'lib/src/scanner',
48 'lib/src/fasta', 47 'lib/src/fasta',
49 'lib/src/fasta/builder', 48 'lib/src/fasta/builder',
50 'lib/src/fasta/dill', 49 'lib/src/fasta/dill',
51 'lib/src/fasta/kernel', 50 'lib/src/fasta/kernel',
52 'lib/src/fasta/parser',
53 'lib/src/fasta/scanner',
54 'lib/src/fasta/source', 51 'lib/src/fasta/source',
55 ]), 52 ]),
56 'lib/src/fasta/builder': new SubpackageRules(allowedDependencies: [ 53 'lib/src/fasta/builder': new SubpackageRules(allowedDependencies: [
57 'lib/src/fasta', 54 'lib/src/fasta',
58 'lib/src/fasta/dill', 55 'lib/src/fasta/dill',
59 'lib/src/fasta/parser', 56 'lib/src/fasta/parser',
60 'lib/src/fasta/source', 57 'lib/src/fasta/source',
61 'lib/src/fasta/util', 58 'lib/src/fasta/util',
62 ]), 59 ]),
63 'lib/src/fasta/dill': new SubpackageRules(allowedDependencies: [ 60 'lib/src/fasta/dill': new SubpackageRules(allowedDependencies: [
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 problem('Uri $src is inside package:front_end but is not in any known ' 232 problem('Uri $src is inside package:front_end but is not in any known '
236 'subpackage'); 233 'subpackage');
237 } else if (!subpackageRules[subpackage].allowSubdirs && 234 } else if (!subpackageRules[subpackage].allowSubdirs &&
238 pathWithinSubpackage.contains('/')) { 235 pathWithinSubpackage.contains('/')) {
239 problem('Uri $src is in a subfolder of $subpackage, but that ' 236 problem('Uri $src is in a subfolder of $subpackage, but that '
240 'subpackage does not allow dart files in subdirectories.'); 237 'subpackage does not allow dart files in subdirectories.');
241 } 238 }
242 return subpackage; 239 return subpackage;
243 } 240 }
244 } 241 }
OLDNEW
« no previous file with comments | « pkg/front_end/test/scanner_roundtrip_test.dart ('k') | pkg/front_end/tool/fasta_perf.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698