Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2756573004: [Dashboard] Formalize SeriesGroup (Closed)

Created:
3 years, 9 months ago by eakuefner
Modified:
3 years, 9 months ago
Reviewers:
sullivan, shatch
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Dashboard] Formalize SeriesGroup This CL abstracts the concept of a SeriesGroup into a class, and in particular, adds a fromLegacyChartStateElement that can be used for restoring charts from a page state. Since fromLegacyChartStateElement performs requests to list_tests, we unit test the formation of the test path dicts. BUG=catapult:#3406 Review-Url: https://codereview.chromium.org/2756573004 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4d5136b8407ed45e76bc71681caff89f2e6a2104

Patch Set 1 #

Patch Set 2 : JSON.parse oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -3 lines) Patch
A dashboard/dashboard/static/series_group.html View 1 1 chunk +109 lines, -0 lines 0 comments Download
A dashboard/dashboard/static/series_group_test.html View 1 1 chunk +65 lines, -0 lines 0 comments Download
M dashboard/dashboard/static/simple_xhr.html View 2 chunks +8 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
eakuefner
PTAL. The next step will be to reland the original CL, using this functionality in ...
3 years, 9 months ago (2017-03-16 22:02:36 UTC) #2
sullivan
lgtm
3 years, 9 months ago (2017-03-16 22:05:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756573004/20001
3 years, 9 months ago (2017-03-16 22:20:59 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 23:04:46 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698