Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2756513004: Remove unused methods from PhysicalWebBleClient (Closed)

Created:
3 years, 9 months ago by cco3
Modified:
3 years, 9 months ago
Reviewers:
nyquist, mattreynolds
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused methods from PhysicalWebBleClient These various subscription methods have been moved out into subclasses of NearbySubscription. BUG=702278 Review-Url: https://codereview.chromium.org/2756513004 Cr-Commit-Position: refs/heads/master@{#458561} Committed: https://chromium.googlesource.com/chromium/src/+/203431000fbc3145c7732a85cadd348378bc7d24

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -61 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java View 4 chunks +0 lines, -61 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
cco3
Hi Matt, here's an easy one.
3 years, 9 months ago (2017-03-16 18:15:55 UTC) #2
mattreynolds
lgtm
3 years, 9 months ago (2017-03-16 19:55:02 UTC) #3
mattreynolds
On 2017/03/16 19:55:02, mattreynolds wrote: > lgtm Oh, and fix the typo in the CL ...
3 years, 9 months ago (2017-03-16 19:55:46 UTC) #4
cco3
Hi Tommy. This is a small cleanup change.
3 years, 9 months ago (2017-03-16 19:56:21 UTC) #6
nyquist
lgtm
3 years, 9 months ago (2017-03-21 20:48:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756513004/20001
3 years, 9 months ago (2017-03-21 20:55:48 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 21:45:03 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/203431000fbc3145c7732a85cadd...

Powered by Google App Engine
This is Rietveld 408576698