[autoroll] make autoroller propagate changes to recipes.py.

[autoroll] make autoroller propagate changes to recipes.py.

The autoroller will now keep the copypasta doc/recipes.py script up to
date.

R=martiniss@chromium.org, nodir@chromium.org, phajdan.jr@chromium.org, vadimsh@chromium.org
BUG=459840
Review-Url: https://codereview.chromium.org/2756503003
Committed: https://github.com/luci/recipes-py/commit/81de92519dd374d9b193362034fae8861476bc5f

[iannucci, 2017-03-16 05:02:57]

This was really bugging me. PTAL!

[iannucci, 2017-03-16 05:19:55]

https://codereview.chromium.org/2756503003/diff/40001/doc/recipes.py
File doc/recipes.py (right):

https://codereview.chromium.org/2756503003/diff/40001/doc/recipes.py#newcode81
doc/recipes.py:81: engine_revision = engine.get('revision', '')
these changes are needed because the autoroller tests now actually put a proper
recipes.py file in place before calling 'train' or whatever. They use a file://
url scheme for the recipe_engine to point at the recipes repo under test (and so
there's no 'revision' string)

https://codereview.chromium.org/2756503003/diff/40001/doc/recipes.py#newcode212
doc/recipes.py:212: if not engine_path and engine_url.startswith('file://'):
this recipes.py file now works correctly with file urls. and this change will
automatically roll downstream! yay!

https://codereview.chromium.org/2756503003/diff/40001/unittests/repo_test_uti...
File unittests/repo_test_util.py (right):

https://codereview.chromium.org/2756503003/diff/40001/unittests/repo_test_uti...
unittests/repo_test_util.py:102: os.path.join(repo_dir, 'infra', 'config',
'recipes.cfg')),
This changed because we now assume that the recipes.py file has a bit more
smarts in it. This is now the minimal assumed recipes.py file.

[Paweł Hajdan Jr., 2017-03-16 16:29:22]

LGTM w/optional suggestion (fine with a TODO, follow-up CL, etc).

https://codereview.chromium.org/2756503003/diff/40001/unittests/repo_test_uti...
File unittests/repo_test_util.py (right):

https://codereview.chromium.org/2756503003/diff/40001/unittests/repo_test_uti...
unittests/repo_test_util.py:102: os.path.join(repo_dir, 'infra', 'config',
'recipes.cfg')),
On 2017/03/16 05:19:55, iannucci wrote:
> This changed because we now assume that the recipes.py file has a bit more
> smarts in it. This is now the minimal assumed recipes.py file.

Consider adding a test for how things behave if expected lines are not present.

[iannucci, 2017-03-19 17:39:02]

https://codereview.chromium.org/2756503003/diff/40001/unittests/repo_test_uti...
File unittests/repo_test_util.py (right):

https://codereview.chromium.org/2756503003/diff/40001/unittests/repo_test_uti...
unittests/repo_test_util.py:102: os.path.join(repo_dir, 'infra', 'config',
'recipes.cfg')),
On 2017/03/16 16:29:22, Paweł Hajdan Jr. wrote:
> On 2017/03/16 05:19:55, iannucci wrote:
> > This changed because we now assume that the recipes.py file has a bit more
> > smarts in it. This is now the minimal assumed recipes.py file.
> 
> Consider adding a test for how things behave if expected lines are not
present.

Done.

[iannucci, 2017-03-19 17:39:13]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-19 17:39:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-19 17:42:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-19 17:42:34]

Dry run: This issue passed the CQ dry run.

[iannucci, 2017-03-20 20:15:15]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2017-03-20 20:15:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/2756503003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-20 20:15:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 20:18:33]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490040915538570,
"parent_rev": "aa0a2d61cd31decf9a5c048b677ba38eb209a1c6", "commit_rev":
"81de92519dd374d9b193362034fae8861476bc5f"}

[commit-bot: I haz the power, 2017-03-20 20:18:37]

Description was changed from

==========
[autoroll] make autoroller propagate changes to recipes.py.

The autoroller will now keep the copypasta doc/recipes.py script up to
date.

R=martiniss@chromium.org, nodir@chromium.org, phajdan.jr@chromium.org,
vadimsh@chromium.org
BUG=459840
==========

to

==========
[autoroll] make autoroller propagate changes to recipes.py.

The autoroller will now keep the copypasta doc/recipes.py script up to
date.

R=martiniss@chromium.org, nodir@chromium.org, phajdan.jr@chromium.org,
vadimsh@chromium.org
BUG=459840

Review-Url: https://codereview.chromium.org/2756503003
Committed:
https://github.com/luci/recipes-py/commit/81de92519dd374d9b193362034fae886147...
==========

[commit-bot: I haz the power, 2017-03-20 20:18:38]

Committed patchset #5 (id:80001) as
https://github.com/luci/recipes-py/commit/81de92519dd374d9b193362034fae886147...