Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2756463002: [Turbofan] Intrinsic lowering of ToString(<str>) should provide <str> (Closed)

Created:
3 years, 9 months ago by mvstanton
Modified:
3 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Intrinsic lowering of ToString(<str>) should provide <str> BUG=v8:6103, chromium:700294 R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2756463002 Cr-Commit-Position: refs/heads/master@{#43838} Committed: https://chromium.googlesource.com/v8/v8/+/7b76d5208314f601231a8222f1b998d9f42fd4fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
mvstanton
Hi Benedikt, here is the bug we discussed, thx for the advice! --Michael
3 years, 9 months ago (2017-03-15 14:35:19 UTC) #3
Benedikt Meurer
Nice, LGTM!
3 years, 9 months ago (2017-03-15 17:55:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756463002/1
3 years, 9 months ago (2017-03-15 18:33:40 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 18:35:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7b76d5208314f601231a8222f1b998d9f42...

Powered by Google App Engine
This is Rietveld 408576698