Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2756443005: Add a partial load test for an animated GIF image (Closed)

Created:
3 years, 9 months ago by Noel Gordon
Modified:
3 years, 9 months ago
Reviewers:
scroggo_chromium
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, darktears, blink-reviews, Eric Willigers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a partial load test for an animated GIF image Use HTTP test load-and-stall script to partially load the initial frame of a animated GIF image. Render the image over CSS background color green and confirm that the CSS color appears in the undecoded regions of the image. TBR=scroggo@chromium.org BUG=702148 Review-Url: https://codereview.chromium.org/2756443005 Cr-Commit-Position: refs/heads/master@{#457428} Committed: https://chromium.googlesource.com/chromium/src/+/7dd150883791d4d7aecf7bb93edb3f733fa11237

Patch Set 1 #

Patch Set 2 : Rebaseline virtual/mojo-loading case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/images/gif-animated-partial-load.html View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756443005/20001
3 years, 9 months ago (2017-03-16 14:18:25 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/7dd150883791d4d7aecf7bb93edb3f733fa11237
3 years, 9 months ago (2017-03-16 14:24:46 UTC) #15
Noel Gordon
On 2017/03/16 14:24:46, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) as ...
3 years, 9 months ago (2017-03-16 22:00:10 UTC) #16
scroggo_chromium
On 2017/03/16 22:00:10, noel gordon wrote: > On 2017/03/16 14:24:46, commit-bot: I haz the power ...
3 years, 9 months ago (2017-03-17 14:15:27 UTC) #17
Noel Gordon
3 years, 9 months ago (2017-03-18 01:37:45 UTC) #18
Message was sent while issue was closed.
On 2017/03/17 14:15:27, scroggo_chromium wrote:
> On 2017/03/16 22:00:10, noel gordon wrote:
> > On 2017/03/16 14:24:46, commit-bot: I haz the power wrote:
> > > Committed patchset #2 (id:20001) as
> > >
> >
>
https://chromium.googlesource.com/chromium/src/+/7dd150883791d4d7aecf7bb93edb...
> > 
> > Does this looks good Leon?
> 
> Should it share code with the APNG test? (crrev.com/2743253009). Otherwise,
lgtm

Could yes, along with the 4 other tests like this.  If it's work worth doing,
and I'm not sure it is, maybe add to the list of work needed to move to using
SkCodec in image decoders if there is such a list?

Powered by Google App Engine
This is Rietveld 408576698