Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2756443002: Loading: extends ReloadCacheControlBrowserTest to cover frame reload (Closed)

Created:
3 years, 9 months ago by Takashi Toyoshima
Modified:
3 years, 9 months ago
Reviewers:
kinuko
CC:
chromium-reviews, loading-reviews_chromium.org, jam, darin-cc_chromium.org, Randy Smith (Not in Mondays), mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Loading: extends ReloadCacheControlBrowserTest to cover frame reload To verify end to end reload behaviors against pages that contains iframes, update ReloadCacheControlBrowserTestt to check cache control flags against a page containing a simple frame in addition to an image resource. BUG=602900 Review-Url: https://codereview.chromium.org/2756443002 Cr-Commit-Position: refs/heads/master@{#457348} Committed: https://chromium.googlesource.com/chromium/src/+/4562d4a8a6cc89ff20222ca0fe082e42a4625c86

Patch Set 1 #

Patch Set 2 : :setlocal spell spelllang=en_us #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -49 lines) Patch
M content/browser/loader/reload_cache_control_browsertest.cc View 1 12 chunks +121 lines, -45 lines 0 comments Download
D content/test/data/loader/reload.html View 1 chunk +0 lines, -5 lines 0 comments Download
A + content/test/data/loader/reload_test.html View 1 chunk +1 line, -0 lines 0 comments Download
A + content/test/data/loader/simple_frame.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Takashi Toyoshima
ptal
3 years, 9 months ago (2017-03-15 11:20:43 UTC) #4
kinuko
lgtm
3 years, 9 months ago (2017-03-15 11:50:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756443002/20001
3 years, 9 months ago (2017-03-16 03:56:23 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4562d4a8a6cc89ff20222ca0fe082e42a4625c86
3 years, 9 months ago (2017-03-16 04:09:51 UTC) #12
findit-for-me
FYI: Findit identified this CL at revision 457348 as the culprit for failures in the ...
3 years, 9 months ago (2017-03-16 06:59:03 UTC) #13
stgao
3 years, 9 months ago (2017-03-24 21:07:36 UTC) #14
Message was sent while issue was closed.
On 2017/03/16 06:59:03, findit-for-me wrote:
> FYI: Findit identified this CL at revision 457348 as the culprit for
> failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

I believe that this CL made ReloadCacheControlBrowserTest.NavigateToSame flaky.
Mind investigating and fixing?

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWV...

Powered by Google App Engine
This is Rietveld 408576698