Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 2756283002: Restore logging of WMPI seek events in media log (Closed)

Created:
3 years, 9 months ago by servolk
Modified:
3 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org, apacible+watch_chromium.org, erickung+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore logging of WMPI seek events in media log There is already an existing MediaLog::CreateLoadEvent function, which used to be called from WMPI, but seems to have been accidentally removed in https://codereview.chromium.org/1641423002. This CL will restore the SEEK event logging in media log and in media-internals UI. Review-Url: https://codereview.chromium.org/2756283002 Cr-Commit-Position: refs/heads/master@{#457940} Committed: https://chromium.googlesource.com/chromium/src/+/86b3d88fbf2cced97264276fb2ec796e828ddf50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M media/base/media_log.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/media_log.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
servolk
3 years, 9 months ago (2017-03-17 21:15:20 UTC) #5
sandersd (OOO until July 31)
lgtm
3 years, 9 months ago (2017-03-17 21:21:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756283002/1
3 years, 9 months ago (2017-03-17 21:25:48 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/403234)
3 years, 9 months ago (2017-03-17 23:20:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756283002/1
3 years, 9 months ago (2017-03-17 23:21:28 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-18 02:51:10 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/86b3d88fbf2cced97264276fb2ec...

Powered by Google App Engine
This is Rietveld 408576698