Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2756253002: Revert of [MD settings] hide extra horizontal scrollbar (Closed)

Created:
3 years, 9 months ago by Dan Beam
Modified:
3 years, 9 months ago
Reviewers:
dschuyler, dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [MD settings] hide extra horizontal scrollbar (patchset #1 id:20001 of https://codereview.chromium.org/2753943003/ ) Reason for revert: The bug this is fixing https://bugs.chromium.org/p/chromium/issues/detail?id=645346 Is not as bad as the bug it introduced https://bugs.chromium.org/p/chromium/issues/detail?id=702496 Original issue's description: > [MD settings] hide extra horizontal scrollbar > > This CL prevents an unwanted horizontal scrollbar from flashing at the > bottom of the page when transitioning from a sub-page back to the basic > page. > > BUG=645346 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2753943003 > Cr-Commit-Position: refs/heads/master@{#457570} > Committed: https://chromium.googlesource.com/chromium/src/+/bfa14e6ef0b8adc0f56d899f3776fe4b960b8978 TBR=dpapad@chromium.org,dschuyler@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=645346 Review-Url: https://codereview.chromium.org/2756253002 Cr-Commit-Position: refs/heads/master@{#457817} Committed: https://chromium.googlesource.com/chromium/src/+/364a557a2bdad974a06b6a74ce46520b26ebba3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/browser/resources/settings/basic_page/basic_page.html View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Dan Beam
Created Revert of [MD settings] hide extra horizontal scrollbar
3 years, 9 months ago (2017-03-17 18:11:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756253002/1
3 years, 9 months ago (2017-03-17 18:12:54 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 18:20:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/364a557a2bdad974a06b6a74ce46...

Powered by Google App Engine
This is Rietveld 408576698