X11: Fix test flakes related to window focus

X11: Fix test flakes related to window focus

This CL removes code intended to fix "some tests depending on a window
being IsActive() immediately after an Activate()".  After
https://codereview.chromium.org/2630773002, all of these cases should
be using WidgetActivationWaiter, so this is unnecessary.  This was
causing DCHECK(!is_active || window_mapped_in_server_) to fail.

In addition, XSetInputFocus on an unmapped window will fail, so
supress the error in this case.  This is the same thing GTK does
https://github.com/GNOME/gtk/blob/7ade6e3f4668220f0fa1382944a87e63691ad9ad/gdk/x11/gdkwindow-x11.c#L1904

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng
BUG=701722, 701921, 701706, 701485, 701484, 700692, 700683, 700661, 701886
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2756183003
Cr-Commit-Position: refs/heads/master@{#457859}
Committed: https://chromium.googlesource.com/chromium/src/+/9b35aa2cb18ff78d6cfc843f0e9414ccb6c22150

[Tom (Use chromium acct), 2017-03-17 18:14:20]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 18:15:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom (Use chromium acct), 2017-03-17 18:24:14]

Description was changed from

==========
X11: Fix test flakes related to window focus

This CL removes code intended to fix "some tests depending on a window
being IsActive() immediately after an Activate()".  After
https://codereview.chromium.org/2630773002, all of these cases should
be using WidgetActivationWaiter, so this is unnecessary.  This was
causing DCHECK(!is_active || window_mapped_in_server_) to fail.

In addition, XSetInputFocus on an unmapped window will fail, so
supress the error in this case.  This is the same thing GTK does
https://github.com/GNOME/gtk/blob/7ade6e3f4668220f0fa1382944a87e63691ad9ad/gd...

BUG=701722,701921,701706,701485,701484,700692,700683,700661,701886
R=erg@chromium.org
==========

to

==========
X11: Fix test flakes related to window focus

This CL removes code intended to fix "some tests depending on a window
being IsActive() immediately after an Activate()".  After
https://codereview.chromium.org/2630773002, all of these cases should
be using WidgetActivationWaiter, so this is unnecessary.  This was
causing DCHECK(!is_active || window_mapped_in_server_) to fail.

In addition, XSetInputFocus on an unmapped window will fail, so
supress the error in this case.  This is the same thing GTK does
https://github.com/GNOME/gtk/blob/7ade6e3f4668220f0fa1382944a87e63691ad9ad/gd...

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng
BUG=701722,701921,701706,701485,701484,700692,700683,700661,701886
R=erg@chromium.org
==========

[Tom (Use chromium acct), 2017-03-17 18:38:21]

erg ptal

This should fix some flakiness on dbg builds after
https://codereview.chromium.org/2630773002

[Elliot Glaysher, 2017-03-17 19:26:43]

lgtm

(also, you write really good change descriptions. thanks for putting all the
details there.)

[commit-bot: I haz the power, 2017-03-17 19:29:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 19:29:23]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2017-03-17 19:30:15]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-03-17 19:30:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 19:45:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489779015544390, "parent_rev":
"fdaf992478720559b046d7f953c99c9728a694c4", "commit_rev":
"9b35aa2cb18ff78d6cfc843f0e9414ccb6c22150"}

[commit-bot: I haz the power, 2017-03-17 19:46:13]

Description was changed from

==========
X11: Fix test flakes related to window focus

This CL removes code intended to fix "some tests depending on a window
being IsActive() immediately after an Activate()".  After
https://codereview.chromium.org/2630773002, all of these cases should
be using WidgetActivationWaiter, so this is unnecessary.  This was
causing DCHECK(!is_active || window_mapped_in_server_) to fail.

In addition, XSetInputFocus on an unmapped window will fail, so
supress the error in this case.  This is the same thing GTK does
https://github.com/GNOME/gtk/blob/7ade6e3f4668220f0fa1382944a87e63691ad9ad/gd...

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng
BUG=701722,701921,701706,701485,701484,700692,700683,700661,701886
R=erg@chromium.org
==========

to

==========
X11: Fix test flakes related to window focus

This CL removes code intended to fix "some tests depending on a window
being IsActive() immediately after an Activate()".  After
https://codereview.chromium.org/2630773002, all of these cases should
be using WidgetActivationWaiter, so this is unnecessary.  This was
causing DCHECK(!is_active || window_mapped_in_server_) to fail.

In addition, XSetInputFocus on an unmapped window will fail, so
supress the error in this case.  This is the same thing GTK does
https://github.com/GNOME/gtk/blob/7ade6e3f4668220f0fa1382944a87e63691ad9ad/gd...

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng
BUG=701722,701921,701706,701485,701484,700692,700683,700661,701886
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2756183003
Cr-Commit-Position: refs/heads/master@{#457859}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b35aa2cb18ff78d6cfc843f0e94...
==========

[commit-bot: I haz the power, 2017-03-17 19:46:13]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b35aa2cb18ff78d6cfc843f0e94...