Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2756153002: Enable ResloadCacheControlBrowserTest.NavigateToSame for PlzNavigate (Closed)

Created:
3 years, 9 months ago by Takashi Toyoshima
Modified:
3 years, 9 months ago
Reviewers:
kinuko
CC:
chromium-reviews, loading-reviews_chromium.org, jam, darin-cc_chromium.org, Randy Smith (Not in Mondays), mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable ResloadCacheControlBrowserTest.NavigateToSame for PlzNavigate This was disabled for a while because it does not work if browser side navigation is enabled. But the problem seems to be already fixed. This patch just re-enables the NavigateToSame test. BypassingReload test is still failing if I try enabling it. Fix will follow soon. BUG=671545 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2756153002 Cr-Commit-Position: refs/heads/master@{#458646} Committed: https://chromium.googlesource.com/chromium/src/+/d48b3d14741301605c1715aef0c323c710b16a79

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/browser/loader/reload_cache_control_browsertest.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Takashi Toyoshima
ptal
3 years, 9 months ago (2017-03-17 11:12:30 UTC) #7
kinuko
lgtm
3 years, 9 months ago (2017-03-21 08:57:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756153002/1
3 years, 9 months ago (2017-03-22 04:59:45 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 06:46:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d48b3d14741301605c1715aef0c3...

Powered by Google App Engine
This is Rietveld 408576698