Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2617)

Unified Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 2756143002: Disable DevToolsBeforeUnloadTest.TestUndockedDevToolsInspectedTabClose and DevToolsBeforeUnloadTest… (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_sanity_browsertest.cc
diff --git a/chrome/browser/devtools/devtools_sanity_browsertest.cc b/chrome/browser/devtools/devtools_sanity_browsertest.cc
index 95636bb2a8975fab37cb4080ebb82a21f6378a3e..54e4e6ab60897a33182ac9eef147c6034ed23b0b 100644
--- a/chrome/browser/devtools/devtools_sanity_browsertest.cc
+++ b/chrome/browser/devtools/devtools_sanity_browsertest.cc
@@ -728,8 +728,16 @@ IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
// Tests that BeforeUnload event gets called on docked devtools if
// we try to close the inspected browser.
+// Flaky on Windows. http://crbug.com/702171
+#if defined(OS_WIN)
+#define MAYBE_TestDockedDevToolsInspectedBrowserClose \
+ DISABLED_TestDockedDevToolsInspectedBrowserClose
+#else
+#define MAYBE_TestDockedDevToolsInspectedBrowserClose \
+ TestDockedDevToolsInspectedBrowserClose
+#endif
IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
- TestDockedDevToolsInspectedBrowserClose) {
+ MAYBE_TestDockedDevToolsInspectedBrowserClose) {
RunBeforeUnloadSanityTest(true, base::Bind(
&DevToolsBeforeUnloadTest::CloseInspectedBrowser,
base::Unretained(this)));
@@ -752,6 +760,14 @@ IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
// Tests that BeforeUnload event gets called on undocked devtools if
// we try to close the inspected page.
+// Flaky on Windows. http://crbug.com/702171
+#if defined(OS_WIN)
+#define MAYBE_TestUndockedDevToolsInspectedTabClose \
+ DISABLED_TestUndockedDevToolsInspectedTabClose
+#else
+#define MAYBE_TestUndockedDevToolsInspectedTabClose \
+ TestUndockedDevToolsInspectedTabClose
+#endif
IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
TestUndockedDevToolsInspectedTabClose) {
RunBeforeUnloadSanityTest(false, base::Bind(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698