Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 2756143002: Disable DevToolsBeforeUnloadTest.TestUndockedDevToolsInspectedTabClose and DevToolsBeforeUnloadTest… (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/cancelable_callback.h" 10 #include "base/cancelable_callback.h"
(...skipping 710 matching lines...) Expand 10 before | Expand all | Expand 10 after
721 #endif 721 #endif
722 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest, 722 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
723 MAYBE_TestDockedDevToolsInspectedTabClose) { 723 MAYBE_TestDockedDevToolsInspectedTabClose) {
724 RunBeforeUnloadSanityTest(true, base::Bind( 724 RunBeforeUnloadSanityTest(true, base::Bind(
725 &DevToolsBeforeUnloadTest::CloseInspectedTab, 725 &DevToolsBeforeUnloadTest::CloseInspectedTab,
726 base::Unretained(this))); 726 base::Unretained(this)));
727 } 727 }
728 728
729 // Tests that BeforeUnload event gets called on docked devtools if 729 // Tests that BeforeUnload event gets called on docked devtools if
730 // we try to close the inspected browser. 730 // we try to close the inspected browser.
731 // Flaky on Windows. http://crbug.com/702171
732 #if defined(OS_WIN)
733 #define MAYBE_TestDockedDevToolsInspectedBrowserClose \
734 DISABLED_TestDockedDevToolsInspectedBrowserClose
735 #else
736 #define MAYBE_TestDockedDevToolsInspectedBrowserClose \
737 TestDockedDevToolsInspectedBrowserClose
738 #endif
731 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest, 739 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
732 TestDockedDevToolsInspectedBrowserClose) { 740 MAYBE_TestDockedDevToolsInspectedBrowserClose) {
733 RunBeforeUnloadSanityTest(true, base::Bind( 741 RunBeforeUnloadSanityTest(true, base::Bind(
734 &DevToolsBeforeUnloadTest::CloseInspectedBrowser, 742 &DevToolsBeforeUnloadTest::CloseInspectedBrowser,
735 base::Unretained(this))); 743 base::Unretained(this)));
736 } 744 }
737 745
738 // Tests that BeforeUnload event gets called on undocked devtools if 746 // Tests that BeforeUnload event gets called on undocked devtools if
739 // we try to close them. 747 // we try to close them.
740 // Flaky on Windows, Linux and ChromiumOS. http://crbug.com/702171 748 // Flaky on Windows, Linux and ChromiumOS. http://crbug.com/702171
741 #if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_CHROMEOS) 749 #if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_CHROMEOS)
742 #define MAYBE_TestUndockedDevToolsClose DISABLED_TestUndockedDevToolsClose 750 #define MAYBE_TestUndockedDevToolsClose DISABLED_TestUndockedDevToolsClose
743 #else 751 #else
744 #define MAYBE_TestUndockedDevToolsClose TestUndockedDevToolsClose 752 #define MAYBE_TestUndockedDevToolsClose TestUndockedDevToolsClose
745 #endif 753 #endif
746 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest, 754 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
747 MAYBE_TestUndockedDevToolsClose) { 755 MAYBE_TestUndockedDevToolsClose) {
748 RunBeforeUnloadSanityTest(false, base::Bind( 756 RunBeforeUnloadSanityTest(false, base::Bind(
749 &DevToolsBeforeUnloadTest::CloseDevToolsWindowAsync, 757 &DevToolsBeforeUnloadTest::CloseDevToolsWindowAsync,
750 base::Unretained(this)), false); 758 base::Unretained(this)), false);
751 } 759 }
752 760
753 // Tests that BeforeUnload event gets called on undocked devtools if 761 // Tests that BeforeUnload event gets called on undocked devtools if
754 // we try to close the inspected page. 762 // we try to close the inspected page.
763 // Flaky on Windows. http://crbug.com/702171
764 #if defined(OS_WIN)
765 #define MAYBE_TestUndockedDevToolsInspectedTabClose \
766 DISABLED_TestUndockedDevToolsInspectedTabClose
767 #else
768 #define MAYBE_TestUndockedDevToolsInspectedTabClose \
769 TestUndockedDevToolsInspectedTabClose
770 #endif
755 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest, 771 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
756 TestUndockedDevToolsInspectedTabClose) { 772 TestUndockedDevToolsInspectedTabClose) {
757 RunBeforeUnloadSanityTest(false, base::Bind( 773 RunBeforeUnloadSanityTest(false, base::Bind(
758 &DevToolsBeforeUnloadTest::CloseInspectedTab, 774 &DevToolsBeforeUnloadTest::CloseInspectedTab,
759 base::Unretained(this))); 775 base::Unretained(this)));
760 } 776 }
761 777
762 // Tests that BeforeUnload event gets called on undocked devtools if 778 // Tests that BeforeUnload event gets called on undocked devtools if
763 // we try to close the inspected browser. 779 // we try to close the inspected browser.
764 // Flaky on Windows, Linux and ChromiumOS. http://crbug.com/702171 780 // Flaky on Windows, Linux and ChromiumOS. http://crbug.com/702171
(...skipping 807 matching lines...) Expand 10 before | Expand all | Expand 10 after
1572 RunTestFunction(window, "testWindowInitializedOnNavigateBack"); 1588 RunTestFunction(window, "testWindowInitializedOnNavigateBack");
1573 1589
1574 DevToolsWindowTesting::CloseDevToolsWindowSync(window); 1590 DevToolsWindowTesting::CloseDevToolsWindowSync(window);
1575 content::WebUIControllerFactory::UnregisterFactoryForTesting(&test_factory); 1591 content::WebUIControllerFactory::UnregisterFactoryForTesting(&test_factory);
1576 } 1592 }
1577 1593
1578 // Tests scripts panel showing. 1594 // Tests scripts panel showing.
1579 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestDevToolsSharedWorker) { 1595 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestDevToolsSharedWorker) {
1580 RunTest("testDevToolsSharedWorker", url::kAboutBlankURL); 1596 RunTest("testDevToolsSharedWorker", url::kAboutBlankURL);
1581 } 1597 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698