Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(80)

Issue 2756133002: Add a test to load PDFs from FTP (Closed)

Created:
1 year, 2 months ago by Lei Zhang
Modified:
1 year, 2 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test to load PDFs from FTP Simplify repetitive code in test file. BUG=694845 Review-Url: https://codereview.chromium.org/2756133002 Cr-Commit-Position: refs/heads/master@{#458162} Committed: https://chromium.googlesource.com/chromium/src/+/fb22f88512765b36c74766d5766e443cc3202b1a

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -90 lines) Patch
M chrome/browser/pdf/pdf_extension_test.cc View 1 41 chunks +75 lines, -90 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Lei Zhang
I synced back to right before https://crbug.com/656956 got fixed, and verified this test reproduces the ...
1 year, 2 months ago (2017-03-18 00:04:26 UTC) #6
Tom Sepez
lgtm
1 year, 2 months ago (2017-03-20 17:18:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756133002/20001
1 year, 2 months ago (2017-03-20 18:40:57 UTC) #13
commit-bot: I haz the power
1 year, 2 months ago (2017-03-20 20:16:25 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fb22f88512765b36c74766d5766e...

Powered by Google App Engine
This is Rietveld 408576698