Chromium Code Reviews
Help | Chromium Project | Sign in
(13)

Issue 2756133002: Add a test to load PDFs from FTP (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 6 days ago by Lei Zhang
Modified:
1 week, 2 days ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test to load PDFs from FTP Simplify repetitive code in test file. BUG=694845 Review-Url: https://codereview.chromium.org/2756133002 Cr-Commit-Position: refs/heads/master@{#458162} Committed: https://chromium.googlesource.com/chromium/src/+/fb22f88512765b36c74766d5766e443cc3202b1a

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -90 lines) Patch
M chrome/browser/pdf/pdf_extension_test.cc View 1 41 chunks +75 lines, -90 lines 0 comments Download
Trybot results:  linux_chromium_asan_rel_ng   ios-device-xcode-clang   linux_chromium_rel_ng   ios-device   linux_chromium_chromeos_rel_ng   win_clang   win_chromium_rel_ng   linux_chromium_tsan_rel_ng   ios-simulator-xcode-clang   linux_chromium_asan_rel_ng   win_chromium_x64_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_compile_dbg_ng   win_chromium_compile_dbg_ng   mac_chromium_compile_dbg_ng   mac_chromium_rel_ng   ios-simulator   linux_android_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   chromium_presubmit   chromeos_daisy_chromium_compile_only_ng   cast_shell_linux   android_cronet   android_n5x_swarming_rel   android_arm64_dbg_recipe   android_compile_dbg   cast_shell_android   android_clang_dbg_recipe   mac_chromium_rel_ng   android_clang_dbg_recipe   linux_chromium_tsan_rel_ng   cast_shell_android   linux_android_rel_ng   linux_chromium_asan_rel_ng   chromium_presubmit   linux_chromium_compile_dbg_ng   win_chromium_rel_ng   chromeos_daisy_chromium_compile_only_ng   linux_chromium_chromeos_rel_ng   linux_chromium_chromeos_ozone_rel_ng   android_compile_dbg   chromeos_amd64-generic_chromium_compile_only_ng   win_chromium_x64_rel_ng   ios-device-xcode-clang   ios-device   win_chromium_compile_dbg_ng   android_cronet   win_clang   mac_chromium_compile_dbg_ng   android_n5x_swarming_rel   ios-simulator-xcode-clang   linux_chromium_rel_ng   ios-simulator   cast_shell_linux   android_arm64_dbg_recipe 
Commit queue not available (can’t edit this change).

Messages

Total messages: 16 (12 generated)
Lei Zhang
I synced back to right before https://crbug.com/656956 got fixed, and verified this test reproduces the ...
1 week, 5 days ago (2017-03-18 00:04:26 UTC) #6
Tom Sepez
lgtm
1 week, 2 days ago (2017-03-20 17:18:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756133002/20001
1 week, 2 days ago (2017-03-20 18:40:57 UTC) #13
commit-bot: I haz the power
1 week, 2 days ago (2017-03-20 20:16:25 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fb22f88512765b36c74766d5766e...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46