Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2756113003: Revert of Reduce runtime of osc-negative-freq test (Closed)

Created:
3 years, 9 months ago by nhiroki
Modified:
3 years, 9 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reduce runtime of osc-negative-freq test (patchset #3 id:40001 of https://codereview.chromium.org/2751213002/ ) Reason for revert: After this patch, osc-negative-freq.html is consistently failing on WebKit Mac10.11 (retina): https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/builds/13573 Original issue's description: > Reduce runtime of osc-negative-freq test > > Reduce the sample rate and duration of the osc-negative-freq test to > make it run faster for MSAN tests. Tightened up the thresholds for > the new test. > > On a Z620 machine running linux, the debug runtime was 1.414 sec. It > is now 0.860, roughtly 60% as long as before. > > BUG=701418 > TEST=osc-negative-freq.html > > Review-Url: https://codereview.chromium.org/2751213002 > Cr-Commit-Position: refs/heads/master@{#457608} > Committed: https://chromium.googlesource.com/chromium/src/+/db917052bfb936546b2602cdb657c310778c6451 TBR=hongchan@chromium.org,qyearsley@chromium.org,rtoy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=701418 Review-Url: https://codereview.chromium.org/2756113003 Cr-Commit-Position: refs/heads/master@{#457708} Committed: https://chromium.googlesource.com/chromium/src/+/cbe096e8f2ab682af6291cbe13a00f21839c7bc8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-negative-freq.html View 7 chunks +9 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
nhiroki
Created Revert of Reduce runtime of osc-negative-freq test
3 years, 9 months ago (2017-03-17 07:19:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756113003/1
3 years, 9 months ago (2017-03-17 07:19:50 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 07:21:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cbe096e8f2ab682af6291cbe13a0...

Powered by Google App Engine
This is Rietveld 408576698