DevTools: remove SDK.ResourceTreeFrame.fromXXX methods

DevTools: remove SDK.ResourceTreeFrame.fromXXX methods
    
This patch makes NetworkProject to operate frameIds instead of
frame objects. Today, we query ResourceTreeModel every time we want to
add/remove UISourceCode. Sometimes resourceTreeModel removes frames
before NetworkProject removes associated resources (e.g. during
MainFrameNavigated), and our query fails.
    
Relying on frameId's instead of frames removes NetworkProject dependency
on ResourceTreeModel and its frame lifecycle.
    
As a result, all the SDK.ResourceTreeFrame.fromXXX methods are
not needed any more.
    
BUG=670180
R=dgozman

Review-Url: https://codereview.chromium.org/2756103002
Cr-Commit-Position: refs/heads/master@{#457931}
Committed: https://chromium.googlesource.com/chromium/src/+/df3c60756d51e4db3b19133b7972c866ca49d027

[lushnikov, 2017-03-17 04:55:49]

please, take a look

[lushnikov, 2017-03-17 04:55:54]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 04:56:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 06:34:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 06:34:16]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-03-17 19:00:21]

https://codereview.chromium.org/2756103002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
(right):

https://codereview.chromium.org/2756103002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js:392:
Bindings.CompilerScriptMapping._frameSymbol =
Symbol('Bindings.CompilerScriptMapping._frameSymbol');
Unused.

https://codereview.chromium.org/2756103002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js
(right):

https://codereview.chromium.org/2756103002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js:345: var
frameId = frame ? frame.id : '';
frame is annotated as non-null here.

https://codereview.chromium.org/2756103002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js:428: var
frame = SDK.ResourceTreeFrame.fromScript(script);
Get the frameId manually similar to the _parsedScriptSource?

https://codereview.chromium.org/2756103002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js
(left):

https://codereview.chromium.org/2756103002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js:68:
contentProvider, SDK.ResourceTreeFrame.fromStyleSheet(header), false,
embeddedContentLength);
I think you can cleanup SDK.ResourceTreeFrame.fromXXX methods now.

https://codereview.chromium.org/2756103002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js (right):

https://codereview.chromium.org/2756103002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js:227:
this.dispatchEventToListeners(SDK.CSSModel.Events.SourceMapDetached, {header:
header, sourceMap: sourceMap});
This removes source map sources whenever first header goes away. For example,
shadow dom stuff breaks.

[lushnikov, 2017-03-17 21:20:33]

Description was changed from

==========
DevTools: cleanup CSS sourcemap sources when sourcemap gets detached

This patch removes CSS sourcemap sources as the sourcemap
gets detached.

This patch also makes NetworkProject to operate frameIds instead of
frame objects. Today, we query ResourceTreeModel every time we want to
add/remove UISourceCode. Sometimes resourceTreeModel removes frames
before NetworkProject removes associated resources (e.g. during
MainFrameNavigated), and our query fails.

Relying on frameId's instead of frames removes NetworkProject dependency
on ResourceTreeModel and its frame lifecycle.

BUG=670180
R=dgozman
==========

to

==========
DevTools: remove SDK.ResourceTreeFrame.fromXXX methods
    
This patch makes NetworkProject to operate frameIds instead of
frame objects. Today, we query ResourceTreeModel every time we want to
add/remove UISourceCode. Sometimes resourceTreeModel removes frames
before NetworkProject removes associated resources (e.g. during
MainFrameNavigated), and our query fails.
    
Relying on frameId's instead of frames removes NetworkProject dependency
on ResourceTreeModel and its frame lifecycle.
    
As a result, all the SDK.ResourceTreeFrame.fromXXX methods are
not needed any more.
    
BUG=670180
R=dgozman
==========

[lushnikov, 2017-03-17 21:21:47]

https://codereview.chromium.org/2756103002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
(right):

https://codereview.chromium.org/2756103002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js:392:
Bindings.CompilerScriptMapping._frameSymbol =
Symbol('Bindings.CompilerScriptMapping._frameSymbol');
On 2017/03/17 19:00:21, dgozman wrote:
> Unused.

Done.

https://codereview.chromium.org/2756103002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js
(right):

https://codereview.chromium.org/2756103002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js:345: var
frameId = frame ? frame.id : '';
On 2017/03/17 19:00:21, dgozman wrote:
> frame is annotated as non-null here.

Done.

https://codereview.chromium.org/2756103002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js:428: var
frame = SDK.ResourceTreeFrame.fromScript(script);
On 2017/03/17 19:00:21, dgozman wrote:
> Get the frameId manually similar to the _parsedScriptSource?

Done.

https://codereview.chromium.org/2756103002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js
(left):

https://codereview.chromium.org/2756103002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js:68:
contentProvider, SDK.ResourceTreeFrame.fromStyleSheet(header), false,
embeddedContentLength);
On 2017/03/17 19:00:21, dgozman wrote:
> I think you can cleanup SDK.ResourceTreeFrame.fromXXX methods now.

YAY! Done.

https://codereview.chromium.org/2756103002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js (right):

https://codereview.chromium.org/2756103002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js:227:
this.dispatchEventToListeners(SDK.CSSModel.Events.SourceMapDetached, {header:
header, sourceMap: sourceMap});
On 2017/03/17 19:00:21, dgozman wrote:
> This removes source map sources whenever first header goes away. For example,
> shadow dom stuff breaks.

I started writing tests and it turned out that we already are not doing proper
job in resolving sourcemap urls. I'll address the issue separately; let's land
the frameId usage for now

[dgozman, 2017-03-17 21:40:54]

lgtm

[lushnikov, 2017-03-17 21:42:03]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-03-17 21:42:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 23:41:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 23:41:57]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lushnikov, 2017-03-18 00:27:00]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-03-18 00:27:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 02:26:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489796820036100,
"parent_rev": "84e9516dcbbc2e25aeb7fd50d5458938c3fc456e", "commit_rev":
"df3c60756d51e4db3b19133b7972c866ca49d027"}

[commit-bot: I haz the power, 2017-03-18 02:26:52]

Description was changed from

==========
DevTools: remove SDK.ResourceTreeFrame.fromXXX methods
    
This patch makes NetworkProject to operate frameIds instead of
frame objects. Today, we query ResourceTreeModel every time we want to
add/remove UISourceCode. Sometimes resourceTreeModel removes frames
before NetworkProject removes associated resources (e.g. during
MainFrameNavigated), and our query fails.
    
Relying on frameId's instead of frames removes NetworkProject dependency
on ResourceTreeModel and its frame lifecycle.
    
As a result, all the SDK.ResourceTreeFrame.fromXXX methods are
not needed any more.
    
BUG=670180
R=dgozman
==========

to

==========
DevTools: remove SDK.ResourceTreeFrame.fromXXX methods
    
This patch makes NetworkProject to operate frameIds instead of
frame objects. Today, we query ResourceTreeModel every time we want to
add/remove UISourceCode. Sometimes resourceTreeModel removes frames
before NetworkProject removes associated resources (e.g. during
MainFrameNavigated), and our query fails.
    
Relying on frameId's instead of frames removes NetworkProject dependency
on ResourceTreeModel and its frame lifecycle.
    
As a result, all the SDK.ResourceTreeFrame.fromXXX methods are
not needed any more.
    
BUG=670180
R=dgozman

Review-Url: https://codereview.chromium.org/2756103002
Cr-Commit-Position: refs/heads/master@{#457931}
Committed:
https://chromium.googlesource.com/chromium/src/+/df3c60756d51e4db3b19133b7972...
==========

[commit-bot: I haz the power, 2017-03-18 02:26:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/df3c60756d51e4db3b19133b7972...