Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2756083002: Handle fallback content case in FlatTreeTraversal::traverseSiblings() (Closed)

Created:
3 years, 9 months ago by kochi
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Handle fallback content case in FlatTreeTraversal::traverseSiblings() FlatTreeTraversal::nextSibling()/previousSibling() didn't handle fallback content (nodes in <slot> where nothing is distributed). This CL adds fallback content handling and a unit test case. BUG=683776 Review-Url: https://codereview.chromium.org/2749033006 Cr-Commit-Position: refs/heads/master@{#457399} (cherry picked from commit b1c7a1d78f6c79f18f1686014a81b86abfb38806) Review-Url: https://codereview.chromium.org/2756083002 . Cr-Commit-Position: refs/branch-heads/3029@{#253} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/b8e8f038e206c970e47d608a8181ef8f281d5c17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversalTest.cpp View 1 chunk +100 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kochi
3 years, 9 months ago (2017-03-17 02:02:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b8e8f038e206c970e47d608a8181ef8f281d5c17.

Powered by Google App Engine
This is Rietveld 408576698