Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 2756063003: Replace sequence with FrozenArray in DetectedBarcode.idl. (Closed)

Created:
3 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 9 months ago
Reviewers:
mcasas
CC:
chromium-reviews, haraken, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace sequence with FrozenArray in DetectedBarcode.idl. It is invalid to use a sequence as an attribute type. I have submitted a pull request to the shape detection API specification to fix this there as well: https://github.com/WICG/shape-detection-api/pull/24 BUG=702582 Review-Url: https://codereview.chromium.org/2756063003 Cr-Commit-Position: refs/heads/master@{#457936} Committed: https://chromium.googlesource.com/chromium/src/+/fc4d9edc3304b2291bae8f93745654bedc2c2ecd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Reilly Grant (use Gerrit)
PTAL
3 years, 9 months ago (2017-03-17 23:58:22 UTC) #3
mcasas
lgtm
3 years, 9 months ago (2017-03-18 01:45:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756063003/1
3 years, 9 months ago (2017-03-18 01:50:57 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-18 02:43:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc4d9edc3304b2291bae8f937456...

Powered by Google App Engine
This is Rietveld 408576698