Abstracting parameters passed to child processes on Android.

Abstracting parameters passed to child processes on Android.

Making the parameters passed to a child process part of a Bundle as part
of the effort to move child process launcher code to base/.

BUG=702316
Review-Url: https://codereview.chromium.org/2756053002
Cr-Commit-Position: refs/heads/master@{#457679}
Committed: https://chromium.googlesource.com/chromium/src/+/9796a271448f237118bbc54316c664a678ada68b

[Jay Civelli, 2017-03-17 00:39:45]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 00:40:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 01:28:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 01:28:37]

Dry run: This issue passed the CQ dry run.

[Jay Civelli, 2017-03-17 02:22:49]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[Jay Civelli, 2017-03-17 02:22:57]

Description was changed from

==========
Abstracting parameters passed to child processes on Android.

Making the parameters passed to a child process part of a Bundle as part
of the effort to move child process launcher code to base/.

BUG=702316
==========

to

==========
Abstracting parameters passed to child processes on Android.

Making the parameters passed to a child process part of a Bundle as part
of the effort to move child process launcher code to base/.

BUG=702316
==========

[Jay Civelli, 2017-03-17 02:22:58]

jcivelli@chromium.org changed reviewers:
+ boliu@chromium.org

[commit-bot: I haz the power, 2017-03-17 02:23:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2017-03-17 02:51:39]

lgtm

https://codereview.chromium.org/2756053002/diff/40001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
(right):

https://codereview.chromium.org/2756053002/diff/40001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java:77:
private Bundle mChildProcessCommonParameters;
final?

https://codereview.chromium.org/2756053002/diff/40001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
(right):

https://codereview.chromium.org/2756053002/diff/40001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java:415:
ChildProcessConstants.EXTRA_LINKER_PARAMS, getLinkerParamsForNewConnection());
maybe getLinkerParamsForNewConnection should be changed to getCommonParamsBundle
or something like that..?

[Jay Civelli, 2017-03-17 03:01:02]

https://codereview.chromium.org/2756053002/diff/40001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
(right):

https://codereview.chromium.org/2756053002/diff/40001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java:77:
private Bundle mChildProcessCommonParameters;
On 2017/03/17 02:51:39, boliu wrote:
> final?

Done.

https://codereview.chromium.org/2756053002/diff/40001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
(right):

https://codereview.chromium.org/2756053002/diff/40001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java:415:
ChildProcessConstants.EXTRA_LINKER_PARAMS, getLinkerParamsForNewConnection());
On 2017/03/17 02:51:39, boliu wrote:
> maybe getLinkerParamsForNewConnection should be changed to
getCommonParamsBundle
> or something like that..?

It's still the linker specific param, so I think the name still makes sense.
Eventually that code will be moved to a delegate once we abstract fully
ChildProcessLauncher.

[Jay Civelli, 2017-03-17 03:01:14]

The CQ bit was checked by jcivelli@chromium.org

[Jay Civelli, 2017-03-17 03:01:14]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2756053002/#ps60001
(title: "Addressed boliu@'s comments.")

[commit-bot: I haz the power, 2017-03-17 03:01:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 03:45:15]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489719674392470,
"parent_rev": "16ddbc9a801d1689cf110d947ebd5f680a2701c8", "commit_rev":
"9796a271448f237118bbc54316c664a678ada68b"}

[commit-bot: I haz the power, 2017-03-17 03:45:55]

Description was changed from

==========
Abstracting parameters passed to child processes on Android.

Making the parameters passed to a child process part of a Bundle as part
of the effort to move child process launcher code to base/.

BUG=702316
==========

to

==========
Abstracting parameters passed to child processes on Android.

Making the parameters passed to a child process part of a Bundle as part
of the effort to move child process launcher code to base/.

BUG=702316

Review-Url: https://codereview.chromium.org/2756053002
Cr-Commit-Position: refs/heads/master@{#457679}
Committed:
https://chromium.googlesource.com/chromium/src/+/9796a271448f237118bbc54316c6...
==========

[commit-bot: I haz the power, 2017-03-17 03:45:56]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9796a271448f237118bbc54316c6...