|
|
Created:
3 years, 9 months ago by jungshik at Google Modified:
3 years, 8 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll third_party/icu from 450be73 to b34251f
http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..b34251f
Changes include (along with minor data build script updates):
1. f0449ad Update IANA timezone db to 2017a from 2016i
2. c781b5f Drops unused Hans-Hant ICU transliteration data.
( cuts down the ICU data file size by ~25kB.)
3. d5c238d Update trim_data to deal with locale fallback failure for units
and fix root_subset.txt in ICU's transliteration configuration.
4. b34251f Update timezone db to 2017b
BUG=684609, 473288, 707515, 677043
TEST=components_unittests --gtest_filter=AutofillProfileComparato*
TEST=ui_base_unittests --gtest_filter=L10nUtilTest.TimeDurationForm*
TEST=For timezone change test, see CL #1 and #4 TEST lines.
TBR=riesa@chromium.org,derat@chromium.org
Review-Url: https://codereview.chromium.org/2755963002
Cr-Commit-Position: refs/heads/master@{#463856}
Committed: https://chromium.googlesource.com/chromium/src/+/cf65b91bc7496b3dd2c958c890984e73c26ad22c
Patch Set 1 #Patch Set 2 : enable TimeDurationFormatAllLocales and roll ICU to b34251f #Messages
Total messages: 33 (26 generated)
Description was changed from ========== Roll third_party/icu from 450be73 to f0449ad http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..f0449ad Two main changes are (along with minor data build script updates): 1. f0449ad Update IANA timezone db to 2017a from 2016i 2. c781b5f Drops unused Hans-Hant ICU transliteration data BUG=684609,473288 TEST=Try the following in d8 or Chrome's JS console: > (new Date("4/4/2017 12:00Z")).toLocaleString("en", {timeZone: "Asia/Ulaanbaatar"}) "4/4/2016, 8:00:00 PM" > (new Date("4/4/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Ulaanbaatar"}) "4/4/2016, 9:00:00 PM" ========== to ========== Roll third_party/icu from 450be73 to f0449ad http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..f0449ad Two main changes are (along with minor data build script updates): 1. f0449ad Update IANA timezone db to 2017a from 2016i 2. c781b5f Drops unused Hans-Hant ICU transliteration data BUG=684609,473288 TEST=Try the following in d8 or Chrome's JS console: > (new Date("4/4/2017 12:00Z")).toLocaleString("en", {timeZone: "Asia/Ulaanbaatar"}) "4/4/2016, 8:00:00 PM" > (new Date("4/4/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Ulaanbaatar"}) "4/4/2016, 9:00:00 PM" TBR=riesa@chromium.org ==========
jshin@chromium.org changed reviewers: + riesa@chromium.org
The CQ bit was checked by jshin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jshin@chromium.org
Description was changed from ========== Roll third_party/icu from 450be73 to f0449ad http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..f0449ad Two main changes are (along with minor data build script updates): 1. f0449ad Update IANA timezone db to 2017a from 2016i 2. c781b5f Drops unused Hans-Hant ICU transliteration data BUG=684609,473288 TEST=Try the following in d8 or Chrome's JS console: > (new Date("4/4/2017 12:00Z")).toLocaleString("en", {timeZone: "Asia/Ulaanbaatar"}) "4/4/2016, 8:00:00 PM" > (new Date("4/4/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Ulaanbaatar"}) "4/4/2016, 9:00:00 PM" TBR=riesa@chromium.org ========== to ========== Roll third_party/icu from 450be73 to f0449ad http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..f0449ad Two main changes are (along with minor data build script updates): 1. f0449ad Update IANA timezone db to 2017a from 2016i 2. c781b5f Drops unused Hans-Hant ICU transliteration data BUG=684609,473288 TEST=Try the following in d8 or Chrome's JS console: > (new Date("4/4/2017 12:00Z")).toLocaleString("en", {timeZone: "Asia/Ulaanbaatar"}) "4/4/2016, 8:00:00 PM" > (new Date("4/4/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Ulaanbaatar"}) "4/4/2016, 9:00:00 PM" TBR=riesa@chromium.org ==========
Description was changed from ========== Roll third_party/icu from 450be73 to f0449ad http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..f0449ad Two main changes are (along with minor data build script updates): 1. f0449ad Update IANA timezone db to 2017a from 2016i 2. c781b5f Drops unused Hans-Hant ICU transliteration data BUG=684609,473288 TEST=Try the following in d8 or Chrome's JS console: > (new Date("4/4/2017 12:00Z")).toLocaleString("en", {timeZone: "Asia/Ulaanbaatar"}) "4/4/2016, 8:00:00 PM" > (new Date("4/4/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Ulaanbaatar"}) "4/4/2016, 9:00:00 PM" TBR=riesa@chromium.org ========== to ========== Roll third_party/icu from 450be73 to f0449ad http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..f0449ad Two main changes are (along with minor data build script updates): 1. f0449ad Update IANA timezone db to 2017a from 2016i 2. c781b5f Drops unused Hans-Hant ICU transliteration data #2 cut down the icu data size by ~ 25kB. BUG=684609,473288 TEST=Try the following in d8 or Chrome's JS console: > (new Date("4/4/2017 12:00Z")).toLocaleString("en", {timeZone: "Asia/Ulaanbaatar"}) "4/4/2016, 8:00:00 PM" > (new Date("4/4/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Ulaanbaatar"}) "4/4/2016, 9:00:00 PM" TBR=riesa@chromium.org ==========
The CQ bit was checked by jshin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/03/16 17:11:59, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jshin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Roll third_party/icu from 450be73 to f0449ad http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..f0449ad Two main changes are (along with minor data build script updates): 1. f0449ad Update IANA timezone db to 2017a from 2016i 2. c781b5f Drops unused Hans-Hant ICU transliteration data #2 cut down the icu data size by ~ 25kB. BUG=684609,473288 TEST=Try the following in d8 or Chrome's JS console: > (new Date("4/4/2017 12:00Z")).toLocaleString("en", {timeZone: "Asia/Ulaanbaatar"}) "4/4/2016, 8:00:00 PM" > (new Date("4/4/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Ulaanbaatar"}) "4/4/2016, 9:00:00 PM" TBR=riesa@chromium.org ========== to ========== Roll third_party/icu from 450be73 to b34251f http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..b34251f Changes include (along with minor data build script updates): 1. f0449ad Update IANA timezone db to 2017a from 2016i 2. c781b5f Drops unused Hans-Hant ICU transliteration data 3. d5c238d Update trim_data to deal with locale fallback failure for units 4. b34251f Update timezone db to 2017b BUG=684609,473288,707515,677043 TEST=components_unittests --gtest_filter=AutofillProfileComparato* TEST=ui_base_unittests --gtest_filter=L10nUtilTest.TimeDurationForm* TEST=For timezone change test, see CL #1 and #4 TEST lines. TBR=riesa@chromium.org,dan@chromium.org ==========
Description was changed from ========== Roll third_party/icu from 450be73 to b34251f http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..b34251f Changes include (along with minor data build script updates): 1. f0449ad Update IANA timezone db to 2017a from 2016i 2. c781b5f Drops unused Hans-Hant ICU transliteration data 3. d5c238d Update trim_data to deal with locale fallback failure for units 4. b34251f Update timezone db to 2017b BUG=684609,473288,707515,677043 TEST=components_unittests --gtest_filter=AutofillProfileComparato* TEST=ui_base_unittests --gtest_filter=L10nUtilTest.TimeDurationForm* TEST=For timezone change test, see CL #1 and #4 TEST lines. TBR=riesa@chromium.org,dan@chromium.org ========== to ========== Roll third_party/icu from 450be73 to b34251f http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..b34251f Changes include (along with minor data build script updates): 1. f0449ad Update IANA timezone db to 2017a from 2016i 2. c781b5f Drops unused Hans-Hant ICU transliteration data 3. d5c238d Update trim_data to deal with locale fallback failure for units 4. b34251f Update timezone db to 2017b BUG=684609,473288,707515,677043 TEST=components_unittests --gtest_filter=AutofillProfileComparato* TEST=ui_base_unittests --gtest_filter=L10nUtilTest.TimeDurationForm* TEST=For timezone change test, see CL #1 and #4 TEST lines. TBR=riesa@chromium.org,dan@chromium.org ==========
Description was changed from ========== Roll third_party/icu from 450be73 to b34251f http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..b34251f Changes include (along with minor data build script updates): 1. f0449ad Update IANA timezone db to 2017a from 2016i 2. c781b5f Drops unused Hans-Hant ICU transliteration data 3. d5c238d Update trim_data to deal with locale fallback failure for units 4. b34251f Update timezone db to 2017b BUG=684609,473288,707515,677043 TEST=components_unittests --gtest_filter=AutofillProfileComparato* TEST=ui_base_unittests --gtest_filter=L10nUtilTest.TimeDurationForm* TEST=For timezone change test, see CL #1 and #4 TEST lines. TBR=riesa@chromium.org,dan@chromium.org ========== to ========== Roll third_party/icu from 450be73 to b34251f http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..b34251f Changes include (along with minor data build script updates): 1. f0449ad Update IANA timezone db to 2017a from 2016i 2. c781b5f Drops unused Hans-Hant ICU transliteration data 3. d5c238d Update trim_data to deal with locale fallback failure for units and fix root_subset.txt in ICU's transliteration configuration. 4. b34251f Update timezone db to 2017b BUG=684609,473288,707515,677043 TEST=components_unittests --gtest_filter=AutofillProfileComparato* TEST=ui_base_unittests --gtest_filter=L10nUtilTest.TimeDurationForm* TEST=For timezone change test, see CL #1 and #4 TEST lines. TBR=riesa@chromium.org,dan@chromium.org ==========
The CQ bit was checked by jshin@chromium.org to run a CQ dry run
Description was changed from ========== Roll third_party/icu from 450be73 to b34251f http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..b34251f Changes include (along with minor data build script updates): 1. f0449ad Update IANA timezone db to 2017a from 2016i 2. c781b5f Drops unused Hans-Hant ICU transliteration data 3. d5c238d Update trim_data to deal with locale fallback failure for units and fix root_subset.txt in ICU's transliteration configuration. 4. b34251f Update timezone db to 2017b BUG=684609,473288,707515,677043 TEST=components_unittests --gtest_filter=AutofillProfileComparato* TEST=ui_base_unittests --gtest_filter=L10nUtilTest.TimeDurationForm* TEST=For timezone change test, see CL #1 and #4 TEST lines. TBR=riesa@chromium.org,dan@chromium.org ========== to ========== Roll third_party/icu from 450be73 to b34251f http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..b34251f Changes include (along with minor data build script updates): 1. f0449ad Update IANA timezone db to 2017a from 2016i 2. c781b5f Drops unused Hans-Hant ICU transliteration data 3. d5c238d Update trim_data to deal with locale fallback failure for units and fix root_subset.txt in ICU's transliteration configuration. 4. b34251f Update timezone db to 2017b BUG=684609,473288,707515,677043 TEST=components_unittests --gtest_filter=AutofillProfileComparato* TEST=ui_base_unittests --gtest_filter=L10nUtilTest.TimeDurationForm* TEST=For timezone change test, see CL #1 and #4 TEST lines. TBR=riesa@chromium.org,derat@chromium.org ==========
jshin@chromium.org changed reviewers: + derat@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll third_party/icu from 450be73 to b34251f http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..b34251f Changes include (along with minor data build script updates): 1. f0449ad Update IANA timezone db to 2017a from 2016i 2. c781b5f Drops unused Hans-Hant ICU transliteration data 3. d5c238d Update trim_data to deal with locale fallback failure for units and fix root_subset.txt in ICU's transliteration configuration. 4. b34251f Update timezone db to 2017b BUG=684609,473288,707515,677043 TEST=components_unittests --gtest_filter=AutofillProfileComparato* TEST=ui_base_unittests --gtest_filter=L10nUtilTest.TimeDurationForm* TEST=For timezone change test, see CL #1 and #4 TEST lines. TBR=riesa@chromium.org,derat@chromium.org ========== to ========== Roll third_party/icu from 450be73 to b34251f http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..b34251f Changes include (along with minor data build script updates): 1. f0449ad Update IANA timezone db to 2017a from 2016i 2. c781b5f Drops unused Hans-Hant ICU transliteration data. ( cuts down the ICU data file size by ~25kB.) 3. d5c238d Update trim_data to deal with locale fallback failure for units and fix root_subset.txt in ICU's transliteration configuration. 4. b34251f Update timezone db to 2017b BUG=684609,473288,707515,677043 TEST=components_unittests --gtest_filter=AutofillProfileComparato* TEST=ui_base_unittests --gtest_filter=L10nUtilTest.TimeDurationForm* TEST=For timezone change test, see CL #1 and #4 TEST lines. TBR=riesa@chromium.org,derat@chromium.org ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jshin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from riesa@chromium.org Link to the patchset: https://codereview.chromium.org/2755963002/#ps20001 (title: "enable TimeDurationFormatAllLocales and roll ICU to b34251f")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491956876892850, "parent_rev": "810b810269e4329d50c089c26d77f47ea89b61ef", "commit_rev": "cf65b91bc7496b3dd2c958c890984e73c26ad22c"}
Message was sent while issue was closed.
Description was changed from ========== Roll third_party/icu from 450be73 to b34251f http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..b34251f Changes include (along with minor data build script updates): 1. f0449ad Update IANA timezone db to 2017a from 2016i 2. c781b5f Drops unused Hans-Hant ICU transliteration data. ( cuts down the ICU data file size by ~25kB.) 3. d5c238d Update trim_data to deal with locale fallback failure for units and fix root_subset.txt in ICU's transliteration configuration. 4. b34251f Update timezone db to 2017b BUG=684609,473288,707515,677043 TEST=components_unittests --gtest_filter=AutofillProfileComparato* TEST=ui_base_unittests --gtest_filter=L10nUtilTest.TimeDurationForm* TEST=For timezone change test, see CL #1 and #4 TEST lines. TBR=riesa@chromium.org,derat@chromium.org ========== to ========== Roll third_party/icu from 450be73 to b34251f http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..b34251f Changes include (along with minor data build script updates): 1. f0449ad Update IANA timezone db to 2017a from 2016i 2. c781b5f Drops unused Hans-Hant ICU transliteration data. ( cuts down the ICU data file size by ~25kB.) 3. d5c238d Update trim_data to deal with locale fallback failure for units and fix root_subset.txt in ICU's transliteration configuration. 4. b34251f Update timezone db to 2017b BUG=684609,473288,707515,677043 TEST=components_unittests --gtest_filter=AutofillProfileComparato* TEST=ui_base_unittests --gtest_filter=L10nUtilTest.TimeDurationForm* TEST=For timezone change test, see CL #1 and #4 TEST lines. TBR=riesa@chromium.org,derat@chromium.org Review-Url: https://codereview.chromium.org/2755963002 Cr-Commit-Position: refs/heads/master@{#463856} Committed: https://chromium.googlesource.com/chromium/src/+/cf65b91bc7496b3dd2c958c89098... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/cf65b91bc7496b3dd2c958c89098... |