Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2755963002: Roll third_party/icu from 450be73 to b34251f (Closed)

Created:
3 years, 9 months ago by jungshik at Google
Modified:
3 years, 8 months ago
Reviewers:
Daniel Erat, riesa
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll third_party/icu from 450be73 to b34251f http://chromium.googlesource.com/chromium/deps/icu.git/+log/450be73..b34251f Changes include (along with minor data build script updates): 1. f0449ad Update IANA timezone db to 2017a from 2016i 2. c781b5f Drops unused Hans-Hant ICU transliteration data. ( cuts down the ICU data file size by ~25kB.) 3. d5c238d Update trim_data to deal with locale fallback failure for units and fix root_subset.txt in ICU's transliteration configuration. 4. b34251f Update timezone db to 2017b BUG=684609, 473288, 707515, 677043 TEST=components_unittests --gtest_filter=AutofillProfileComparato* TEST=ui_base_unittests --gtest_filter=L10nUtilTest.TimeDurationForm* TEST=For timezone change test, see CL #1 and #4 TEST lines. TBR=riesa@chromium.org,derat@chromium.org Review-Url: https://codereview.chromium.org/2755963002 Cr-Commit-Position: refs/heads/master@{#463856} Committed: https://chromium.googlesource.com/chromium/src/+/cf65b91bc7496b3dd2c958c890984e73c26ad22c

Patch Set 1 #

Patch Set 2 : enable TimeDurationFormatAllLocales and roll ICU to b34251f #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 33 (26 generated)
jungshik at Google
3 years, 9 months ago (2017-03-16 17:08:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755963002/1
3 years, 9 months ago (2017-03-16 17:09:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755963002/1
3 years, 9 months ago (2017-03-16 17:11:59 UTC) #10
riesa
On 2017/03/16 17:11:59, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 9 months ago (2017-03-16 17:14:57 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/33804)
3 years, 9 months ago (2017-03-16 17:51:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755963002/20001
3 years, 8 months ago (2017-04-12 00:28:37 UTC) #30
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 00:35:38 UTC) #33
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cf65b91bc7496b3dd2c958c89098...

Powered by Google App Engine
This is Rietveld 408576698