Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2755953003: [scheduler] Add RendererScheduler.TaskDurationPerQueueType. (Closed)

Created:
3 years, 9 months ago by altimin
Modified:
3 years, 7 months ago
Reviewers:
haraken, Ilya Sherman, Sami
CC:
chromium-reviews, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[scheduler] Add RendererScheduler.TaskDurationPerQueueType. Complement RendererScheduler.NumberOfTasksPerQueueType metric by reporting total duration of tasks split per queue type. R=skyostil@chromium.org,isherman@chromium.org CC=haraken@chromium.org BUG=702314 Review-Url: https://codereview.chromium.org/2755953003 Cr-Commit-Position: refs/heads/master@{#472216} Committed: https://chromium.googlesource.com/chromium/src/+/0bed265f220fcf4db86ad1356bed9ec274748b54

Patch Set 1 #

Total comments: 16

Patch Set 2 : Address comments #

Total comments: 2

Patch Set 3 : Fix nit #

Total comments: 10

Patch Set 4 : Rebased & addressed comment #

Patch Set 5 : rebased #

Total comments: 4

Patch Set 6 : addressed comments from skyostil@ and isherman@ #

Patch Set 7 : fixed compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -6 lines) Patch
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h View 1 2 3 4 5 3 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc View 1 2 3 4 5 6 4 chunks +44 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 45 (25 generated)
altimin
PTAL
3 years, 9 months ago (2017-03-16 19:09:14 UTC) #2
Ilya Sherman
https://codereview.chromium.org/2755953003/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc (right): https://codereview.chromium.org/2755953003/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc#newcode1796 third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1796: duration.InMicroseconds(), 1, 1000000, 50); Optional nit: The constant 1000000 ...
3 years, 9 months ago (2017-03-16 21:23:44 UTC) #4
altimin
PTAL https://codereview.chromium.org/2755953003/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc (right): https://codereview.chromium.org/2755953003/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc#newcode1796 third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1796: duration.InMicroseconds(), 1, 1000000, 50); On 2017/03/16 21:23:43, Ilya ...
3 years, 9 months ago (2017-03-16 23:44:23 UTC) #7
Ilya Sherman
https://codereview.chromium.org/2755953003/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc (right): https://codereview.chromium.org/2755953003/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc#newcode1812 third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1812: static_cast<int>(TaskQueue::QueueType::COUNT), On 2017/03/16 23:44:23, altimin wrote: > On 2017/03/16 ...
3 years, 9 months ago (2017-03-16 23:58:45 UTC) #8
altimin
https://codereview.chromium.org/2755953003/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc (right): https://codereview.chromium.org/2755953003/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc#newcode1815 third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1815: static_cast<int>(milliseconds)); On 2017/03/16 23:58:45, Ilya Sherman wrote: > On ...
3 years, 9 months ago (2017-03-17 00:24:00 UTC) #10
haraken
https://codereview.chromium.org/2755953003/diff/40001/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc (right): https://codereview.chromium.org/2755953003/diff/40001/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc#newcode1787 third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1787: RecordTaskMetrics(task_queue->GetQueueType(), I'm just curious but wouldn't it be heavy ...
3 years, 9 months ago (2017-03-17 11:59:52 UTC) #15
altimin
https://codereview.chromium.org/2755953003/diff/40001/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc (right): https://codereview.chromium.org/2755953003/diff/40001/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc#newcode1787 third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1787: RecordTaskMetrics(task_queue->GetQueueType(), On 2017/03/17 11:59:51, haraken wrote: > > I'm ...
3 years, 9 months ago (2017-03-17 12:43:12 UTC) #16
Sami
On 2017/03/17 00:24:00, altimin wrote: > https://codereview.chromium.org/2755953003/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc > File > third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc > (right): > > ...
3 years, 9 months ago (2017-03-17 12:53:39 UTC) #17
altimin
On 2017/03/17 12:53:39, Sami wrote: > On 2017/03/17 00:24:00, altimin wrote: > > > https://codereview.chromium.org/2755953003/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc ...
3 years, 9 months ago (2017-03-17 13:04:51 UTC) #18
altimin
https://codereview.chromium.org/2755953003/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2755953003/diff/20001/tools/metrics/histograms/histograms.xml#newcode56059 tools/metrics/histograms/histograms.xml:56059: + with custom scripts accounting for that instead for ...
3 years, 9 months ago (2017-03-17 13:05:01 UTC) #19
Ilya Sherman
https://codereview.chromium.org/2755953003/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc (right): https://codereview.chromium.org/2755953003/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc#newcode1815 third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1815: static_cast<int>(milliseconds)); On 2017/03/17 00:24:00, altimin wrote: > On 2017/03/16 ...
3 years, 9 months ago (2017-03-17 20:27:36 UTC) #20
altimin
https://codereview.chromium.org/2755953003/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc (right): https://codereview.chromium.org/2755953003/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc#newcode1815 third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1815: static_cast<int>(milliseconds)); On 2017/03/17 20:27:36, Ilya Sherman wrote: > On ...
3 years, 9 months ago (2017-03-17 23:49:53 UTC) #21
Ilya Sherman
https://codereview.chromium.org/2755953003/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc (right): https://codereview.chromium.org/2755953003/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc#newcode1815 third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1815: static_cast<int>(milliseconds)); On 2017/03/17 23:49:53, altimin wrote: > On 2017/03/17 ...
3 years, 9 months ago (2017-03-18 01:09:59 UTC) #22
altimin
https://codereview.chromium.org/2867303004/ has landed, PTAL
3 years, 7 months ago (2017-05-15 18:49:28 UTC) #24
Ilya Sherman
Metrics LGTM, thanks. https://codereview.chromium.org/2755953003/diff/80001/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc (right): https://codereview.chromium.org/2755953003/diff/80001/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc#newcode1867 third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1867: base::TimeDelta& total_duration = Optional nit: Maybe ...
3 years, 7 months ago (2017-05-15 22:53:22 UTC) #30
Sami
lgtm https://codereview.chromium.org/2755953003/diff/40001/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc (right): https://codereview.chromium.org/2755953003/diff/40001/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc#newcode1798 third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1798: UMA_HISTOGRAM_ENUMERATION("RendererScheduler.NumberOfTasksPerQueueType", On 2017/03/17 13:05:01, altimin wrote: > On ...
3 years, 7 months ago (2017-05-16 10:45:07 UTC) #33
altimin
https://codereview.chromium.org/2755953003/diff/40001/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc (right): https://codereview.chromium.org/2755953003/diff/40001/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc#newcode1798 third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1798: UMA_HISTOGRAM_ENUMERATION("RendererScheduler.NumberOfTasksPerQueueType", On 2017/05/16 10:45:07, Sami wrote: > On 2017/03/17 ...
3 years, 7 months ago (2017-05-16 11:56:14 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755953003/120001
3 years, 7 months ago (2017-05-16 13:37:56 UTC) #41
haraken
LGTM
3 years, 7 months ago (2017-05-16 14:07:41 UTC) #42
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 21:08:48 UTC) #45
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/0bed265f220fcf4db86ad1356bed...

Powered by Google App Engine
This is Rietveld 408576698