Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2755913002: [Autofill] Include pattern for *.typemap in OWNERS (Closed)

Created:
3 years, 9 months ago by kolos1
Modified:
3 years, 9 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, jam, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Include pattern for *.typemap in OWNERS The pattern for *.typemap is missing in OWNERS. It causes warnings for CLs that change autofill_types.typemap Review-Url: https://codereview.chromium.org/2755913002 Cr-Commit-Position: refs/heads/master@{#457420} Committed: https://chromium.googlesource.com/chromium/src/+/98ab6683b14ab563a0cf86c0395a5aaf7e334658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/autofill/content/common/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
kolos1
Hi Vaclav, Please review this tiny CL. Regards, Maxim
3 years, 9 months ago (2017-03-16 13:34:27 UTC) #2
vabr (Chromium)
LGTM, this matches the pattern I see in other OWNERS files. Cheers, Vaclav
3 years, 9 months ago (2017-03-16 13:39:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755913002/1
3 years, 9 months ago (2017-03-16 13:42:05 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 13:52:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/98ab6683b14ab563a0cf86c0395a...

Powered by Google App Engine
This is Rietveld 408576698