Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2755843002: Remove pre-MD code from WebNotificationTray. (Closed)

Created:
3 years, 9 months ago by Evan Stade
Modified:
3 years, 9 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove pre-MD code from WebNotificationTray. BUG=687803 Review-Url: https://codereview.chromium.org/2755843002 Cr-Commit-Position: refs/heads/master@{#457461} Committed: https://chromium.googlesource.com/chromium/src/+/ed9e4bf5f9558fe1f3d30a92606d263b4f9a2d1a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -31 lines) Patch
M ash/common/system/web_notification/web_notification_tray.cc View 7 chunks +8 lines, -31 lines 1 comment Download

Messages

Total messages: 16 (10 generated)
Evan Stade
https://codereview.chromium.org/2755843002/diff/1/ash/common/system/web_notification/web_notification_tray.cc File ash/common/system/web_notification/web_notification_tray.cc (left): https://codereview.chromium.org/2755843002/diff/1/ash/common/system/web_notification/web_notification_tray.cc#oldcode275 ash/common/system/web_notification/web_notification_tray.cc:275: view_->SetEnabledColor(kWebNotificationColorWithUnread); this isn't necessary because the label's default color ...
3 years, 9 months ago (2017-03-16 00:41:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755843002/1
3 years, 9 months ago (2017-03-16 00:43:03 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 9 months ago (2017-03-16 00:43:04 UTC) #6
James Cook
LGTM. Thanks for cleaning up all this pre-MD stuff.
3 years, 9 months ago (2017-03-16 16:08:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755843002/1
3 years, 9 months ago (2017-03-16 17:03:23 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 17:08:29 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ed9e4bf5f9558fe1f3d30a92606d...

Powered by Google App Engine
This is Rietveld 408576698