Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: ios/chrome/browser/tabs/tab_unittest.mm

Issue 2755823002: Moved |openedByDOM| to WebState's CreateParams and public interface. (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | ios/chrome/browser/ui/browser_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_unittest.mm
diff --git a/ios/chrome/browser/tabs/tab_unittest.mm b/ios/chrome/browser/tabs/tab_unittest.mm
index d2c4a403e3daffc99d34903d7643c18747c03384..fd3799447d580ccfc946423b5b937a81a81d86d0 100644
--- a/ios/chrome/browser/tabs/tab_unittest.mm
+++ b/ios/chrome/browser/tabs/tab_unittest.mm
@@ -193,9 +193,10 @@ void SetUp() override {
mock_web_controller_ =
[OCMockObject niceMockForClass:[CRWWebController class]];
- auto web_state_impl = base::MakeUnique<WebStateImpl>(browser_state);
+ web::WebState::CreateParams create_params(browser_state);
+ auto web_state_impl = base::MakeUnique<WebStateImpl>(create_params);
web_state_impl->SetWebController(mock_web_controller_);
- web_state_impl->GetNavigationManagerImpl().InitializeSession(NO);
+ web_state_impl->GetNavigationManagerImpl().InitializeSession();
web_state_impl_ = web_state_impl.get();
[[[static_cast<OCMockObject*>(mock_web_controller_) stub]
andReturnValue:OCMOCK_VALUE(web_state_impl_)] webStateImpl];
@@ -205,8 +206,9 @@ void SetUp() override {
tab_.reset([[Tab alloc] initWithWebState:std::move(web_state_impl)
model:nil
attachTabHelpers:NO]);
- web::NavigationManager::WebLoadParams params(GURL("chrome://version/"));
- [[tab_ webController] loadWithParams:params];
+ web::NavigationManager::WebLoadParams load_params(
+ GURL("chrome://version/"));
+ [[tab_ webController] loadWithParams:load_params];
// There should be no entries in the history at this point.
history::QueryResults results;
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | ios/chrome/browser/ui/browser_view_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698