Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2130)

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2755823002: Moved |openedByDOM| to WebState's CreateParams and public interface. (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/tabs/tab.mm
diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm
index 63be1a79b034f1a2a533b5a45f81316b177683e8..99690a85d837ee1b06b7b0da84224c70e26a237e 100644
--- a/ios/chrome/browser/tabs/tab.mm
+++ b/ios/chrome/browser/tabs/tab.mm
@@ -482,9 +482,9 @@ - (instancetype)initWithBrowserState:(ios::ChromeBrowserState*)browserState
opener:(Tab*)opener
openedByDOM:(BOOL)openedByDOM
model:(TabModel*)parentModel {
- std::unique_ptr<web::WebStateImpl> webState(
- new web::WebStateImpl(browserState));
- webState->GetNavigationManagerImpl().InitializeSession(openedByDOM);
+ web::WebState::CreateParams params(browserState);
+ params.created_with_opener = openedByDOM;
+ std::unique_ptr<web::WebState> webState = web::WebState::Create(params);
if ([opener navigationManager]) {
web::SerializableUserDataManager* userDataManager =
web::SerializableUserDataManager::FromWebState(webState.get());
@@ -1505,8 +1505,7 @@ - (void)reloadForDesktopUserAgent {
// |reloadURL| will be empty if a page was open by DOM.
GURL reloadURL(lastNonRedirectedItem->GetOriginalRequestURL());
if (reloadURL.is_empty()) {
- DCHECK(
- [[self navigationManagerImpl]->GetSessionController() isOpenedByDOM]);
+ DCHECK(self.webState && self.webState->HasOpener());
reloadURL = lastNonRedirectedItem->GetVirtualURL();
}
« no previous file with comments | « ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios.mm ('k') | ios/chrome/browser/tabs/tab_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698