media: Add build flag for CDM host verification

media: Add build flag for CDM host verification

This helps prevent triggering the CDM host verification path on
platforms and/or Chromium-based browsers that do not support it.

This makes it harder to test this path, but the benefit seems
to be worth it.

BUG=658036, 702009
Review-Url: https://codereview.chromium.org/2755763002
Cr-Commit-Position: refs/heads/master@{#458136}
Committed: https://chromium.googlesource.com/chromium/src/+/c3941031c6919e712edf088c02dc0f1652773b02

[xhwang, 2017-03-15 20:16:53]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 20:17:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 21:21:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 21:21:35]

Dry run: This issue passed the CQ dry run.

[xhwang, 2017-03-15 21:26:35]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 21:27:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 21:31:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 21:31:29]

Dry run: This issue passed the CQ dry run.

[xhwang, 2017-03-15 21:36:16]

Description was changed from

==========
media: Add build flag for CDM host verification

This helps prevent triggering the CDM host verification path on
platforms or in some Chromium-based browsers that do not support
it.

BUG=658036
==========

to

==========
media: Add build flag for CDM host verification

This helps prevent triggering the CDM host verification path on
platforms and/or Chromium-based browsers that do not support it.

This makes it harder to test this path, but the benefit seems
to be worth it.

BUG=658036
==========

[xhwang, 2017-03-15 21:36:16]

xhwang@chromium.org changed reviewers:
+ hmchen@chromium.org, jrummell@chromium.org

[xhwang, 2017-03-15 22:02:59]

PTAL

[xhwang, 2017-03-15 23:40:46]

Description was changed from

==========
media: Add build flag for CDM host verification

This helps prevent triggering the CDM host verification path on
platforms and/or Chromium-based browsers that do not support it.

This makes it harder to test this path, but the benefit seems
to be worth it.

BUG=658036
==========

to

==========
media: Add build flag for CDM host verification

This helps prevent triggering the CDM host verification path on
platforms and/or Chromium-based browsers that do not support it.

This makes it harder to test this path, but the benefit seems
to be worth it.

BUG=658036,702009
==========

[xhwang, 2017-03-15 23:49:58]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 23:50:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 01:37:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 01:37:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xhwang, 2017-03-16 03:18:37]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 03:18:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 04:05:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 04:05:23]

Dry run: This issue passed the CQ dry run.

[xhwang, 2017-03-16 21:14:02]

jrummell / hmchen: kindly ping!

[hmchen1, 2017-03-16 21:21:48]

On 2017/03/16 21:14:02, xhwang_slow wrote:
> jrummell / hmchen: kindly ping!

My understanding of this change is to not allow the chromium-based browser to
use VerifyCdmHost by default. But this flag can be turned on when building
chromium, right? I mean, it is not a google internal flag.

Should we mention it in the design doc or reference for other chromium-based
browsers, e.g., Opera?

[hmchen1, 2017-03-16 22:14:32]

hmchen@google.com changed reviewers:
+ hmchen@google.com

[hmchen1, 2017-03-16 22:14:33]

lgtm

[xhwang, 2017-03-17 16:34:41]

jrummell: kindly ping!

[jrummell, 2017-03-17 16:55:19]

lgtm

[xhwang, 2017-03-17 17:01:57]

xhwang@chromium.org changed reviewers:
+ jam@chromium.org, kerrnel@chromium.org

[xhwang, 2017-03-17 17:01:58]

jam: Please OWNERS review.

kerrnel: FYI

[Greg K, 2017-03-17 17:05:08]

On 2017/03/17 17:01:58, xhwang_slow wrote:
> jam: Please OWNERS review.
> 
> kerrnel: FYI

Thanks for doing this. It seems wise. Is it going to be enabled or disabled on
Linux for now?

- Greg

[xhwang, 2017-03-17 17:27:54]

On 2017/03/17 17:05:08, Greg K wrote:
> On 2017/03/17 17:01:58, xhwang_slow wrote:
> > jam: Please OWNERS review.
> > 
> > kerrnel: FYI
> 
> Thanks for doing this. It seems wise. Is it going to be enabled or disabled on
> Linux for now?
> 
> - Greg

Yes it's disabled on Linux for now. See
https://bugs.chromium.org/p/chromium/issues/detail?id=695353#c18

I was debating on whether I should remove all the linux-specific code. But I
feel keeping it for now will probably be easier if we want to come back and
revisit the issue.

This will also make it easier to disable it on other platforms/browsers if
necessary ;)

[xhwang, 2017-03-20 16:31:30]

jam: kindly ping!

[jam, 2017-03-20 17:09:36]

lgtm

[xhwang, 2017-03-20 17:29:08]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2017-03-20 17:29:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 18:50:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490030948250990,
"parent_rev": "91c48d5816474990959e57b67ad7f50b3472789f", "commit_rev":
"c3941031c6919e712edf088c02dc0f1652773b02"}

[commit-bot: I haz the power, 2017-03-20 18:51:24]

Description was changed from

==========
media: Add build flag for CDM host verification

This helps prevent triggering the CDM host verification path on
platforms and/or Chromium-based browsers that do not support it.

This makes it harder to test this path, but the benefit seems
to be worth it.

BUG=658036,702009
==========

to

==========
media: Add build flag for CDM host verification

This helps prevent triggering the CDM host verification path on
platforms and/or Chromium-based browsers that do not support it.

This makes it harder to test this path, but the benefit seems
to be worth it.

BUG=658036,702009

Review-Url: https://codereview.chromium.org/2755763002
Cr-Commit-Position: refs/heads/master@{#458136}
Committed:
https://chromium.googlesource.com/chromium/src/+/c3941031c6919e712edf088c02dc...
==========

[commit-bot: I haz the power, 2017-03-20 18:51:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c3941031c6919e712edf088c02dc...