Oilpan: Prepare to move select and option elements to Oilpan heap.

Oilpan: Prepare to move select and option elements to Oilpan heap.

BUG=357163
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173745

[wibling-chromium, 2014-05-08 11:48:58]

lgtm

[haraken, 2014-05-08 11:50:24]

LGTM

https://codereview.chromium.org/275573003/diff/20001/Source/core/accessibilit...
File Source/core/accessibility/AXListBox.cpp (right):

https://codereview.chromium.org/275573003/diff/20001/Source/core/accessibilit...
Source/core/accessibility/AXListBox.cpp:68: // would be a WMLElement, but WML
builds don't use accessibility features at all.

What's WML?

https://codereview.chromium.org/275573003/diff/20001/Source/core/accessibilit...
Source/core/accessibility/AXListBox.cpp:105: // would be a WMLElement, but WML
builds don't use accessibility features at all.

Ditto.

[zerny-chromium, 2014-05-08 12:27:34]

lgtm

https://codereview.chromium.org/275573003/diff/20001/Source/core/html/HTMLSel...
File Source/core/html/HTMLSelectElement.h (right):

https://codereview.chromium.org/275573003/diff/20001/Source/core/html/HTMLSel...
Source/core/html/HTMLSelectElement.h:121: void trace(Visitor*);
Nit: virtual OVERRIDE.

[tkent, 2014-05-08 13:14:05]

lgtm

https://codereview.chromium.org/275573003/diff/20001/Source/core/accessibilit...
File Source/core/accessibility/AXListBox.cpp (right):

https://codereview.chromium.org/275573003/diff/20001/Source/core/accessibilit...
Source/core/accessibility/AXListBox.cpp:68: // would be a WMLElement, but WML
builds don't use accessibility features at all.
On 2014/05/08 11:50:24, haraken wrote:
> 
> What's WML?

Wireless Markup Language, which WebKit supported and removed long ago.  The
comment is obsolete.

[keishi, 2014-05-09 01:56:58]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2014-05-09 01:58:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/keishi@chromium.org/275573003/40001

[commit-bot: I haz the power, 2014-05-09 05:03:59]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/7034)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6778)
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/6285)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/6753)

[keishi, 2014-05-09 05:34:35]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2014-05-09 05:36:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/keishi@chromium.org/275573003/60001

[commit-bot: I haz the power, 2014-05-09 09:06:47]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/7052)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6795)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/6769)

[keishi, 2014-05-09 09:27:58]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2014-05-09 09:29:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/keishi@chromium.org/275573003/80001

[commit-bot: I haz the power, 2014-05-09 11:48:23]

Change committed as 173745