Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: Source/core/accessibility/AXListBox.cpp

Issue 275573003: Oilpan: Prepare to move select and option elements to Oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 } 54 }
55 55
56 void AXListBox::addChildren() 56 void AXListBox::addChildren()
57 { 57 {
58 Node* selectNode = m_renderer->node(); 58 Node* selectNode = m_renderer->node();
59 if (!selectNode) 59 if (!selectNode)
60 return; 60 return;
61 61
62 m_haveChildren = true; 62 m_haveChildren = true;
63 63
64 const Vector<HTMLElement*>& listItems = toHTMLSelectElement(selectNode)->lis tItems(); 64 const WillBeHeapVector<RawPtrWillBeMember<HTMLElement> >& listItems = toHTML SelectElement(selectNode)->listItems();
65 unsigned length = listItems.size(); 65 unsigned length = listItems.size();
66 for (unsigned i = 0; i < length; i++) { 66 for (unsigned i = 0; i < length; i++) {
67 // The cast to HTMLElement below is safe because the only other possible listItem type 67 // The cast to HTMLElement below is safe because the only other possible listItem type
68 // would be a WMLElement, but WML builds don't use accessibility feature s at all. 68 // would be a WMLElement, but WML builds don't use accessibility feature s at all.
haraken 2014/05/08 11:50:24 What's WML?
tkent 2014/05/08 13:14:05 Wireless Markup Language, which WebKit supported a
69 AXObject* listOption = listBoxOptionAXObject(listItems[i]); 69 AXObject* listOption = listBoxOptionAXObject(listItems[i]);
70 if (listOption && !listOption->accessibilityIsIgnored()) 70 if (listOption && !listOption->accessibilityIsIgnored())
71 m_children.append(listOption); 71 m_children.append(listOption);
72 } 72 }
73 } 73 }
74 74
75 AXObject* AXListBox::listBoxOptionAXObject(HTMLElement* element) const 75 AXObject* AXListBox::listBoxOptionAXObject(HTMLElement* element) const
76 { 76 {
77 // skip hr elements 77 // skip hr elements
78 if (!element || isHTMLHRElement(*element)) 78 if (!element || isHTMLHRElement(*element))
(...skipping 16 matching lines...) Expand all
95 if (!node) 95 if (!node)
96 return 0; 96 return 0;
97 97
98 LayoutRect parentRect = elementRect(); 98 LayoutRect parentRect = elementRect();
99 99
100 AXObject* listBoxOption = 0; 100 AXObject* listBoxOption = 0;
101 unsigned length = m_children.size(); 101 unsigned length = m_children.size();
102 for (unsigned i = 0; i < length; i++) { 102 for (unsigned i = 0; i < length; i++) {
103 LayoutRect rect = toRenderListBox(m_renderer)->itemBoundingBoxRect(paren tRect.location(), i); 103 LayoutRect rect = toRenderListBox(m_renderer)->itemBoundingBoxRect(paren tRect.location(), i);
104 // The cast to HTMLElement below is safe because the only other possible listItem type 104 // The cast to HTMLElement below is safe because the only other possible listItem type
105 // would be a WMLElement, but WML builds don't use accessibility feature s at all. 105 // would be a WMLElement, but WML builds don't use accessibility feature s at all.
haraken 2014/05/08 11:50:24 Ditto.
106 if (rect.contains(point)) { 106 if (rect.contains(point)) {
107 listBoxOption = m_children[i].get(); 107 listBoxOption = m_children[i].get();
108 break; 108 break;
109 } 109 }
110 } 110 }
111 111
112 if (listBoxOption && !listBoxOption->accessibilityIsIgnored()) 112 if (listBoxOption && !listBoxOption->accessibilityIsIgnored())
113 return listBoxOption; 113 return listBoxOption;
114 114
115 return axObjectCache()->getOrCreate(m_renderer); 115 return axObjectCache()->getOrCreate(m_renderer);
116 } 116 }
117 117
118 } // namespace WebCore 118 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/accessibility/AXListBoxOption.cpp » ('j') | Source/core/html/HTMLSelectElement.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698