Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2755723004: base: Fix bad function pointer casts in xdg-mime. (Closed)

Created:
3 years, 9 months ago by pcc1
Modified:
3 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Fix bad function pointer casts in xdg-mime. Found with -fsanitize=cfi-icall. BUG=701919 R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2755723004 Cr-Commit-Position: refs/heads/master@{#457207} Committed: https://chromium.googlesource.com/chromium/src/+/afd3a7237c9334f87810404c555ebb1245023484

Patch Set 1 #

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -6 lines) Patch
M base/third_party/xdg_mime/README.chromium View 1 1 chunk +1 line, -0 lines 0 comments Download
A base/third_party/xdg_mime/function_casts.patch View 1 1 chunk +44 lines, -0 lines 0 comments Download
M base/third_party/xdg_mime/xdgmime.c View 4 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
pcc1
3 years, 9 months ago (2017-03-15 19:23:34 UTC) #1
Nico
at least edit base\third_party\xdg_mime\README.chromium to mention this (and add a .patch file). ideally upstream this ...
3 years, 9 months ago (2017-03-15 19:32:25 UTC) #2
pcc1
On 2017/03/15 19:32:25, Nico wrote: > at least edit base\third_party\xdg_mime\README.chromium to mention this (and add ...
3 years, 9 months ago (2017-03-15 19:50:49 UTC) #3
Nico
lgtm
3 years, 9 months ago (2017-03-15 19:56:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755723004/20001
3 years, 9 months ago (2017-03-15 19:58:38 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 21:08:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/afd3a7237c9334f87810404c555e...

Powered by Google App Engine
This is Rietveld 408576698