Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2755723003: Make sure the signature of the call method is finalized before involving it (Closed)

Created:
3 years, 9 months ago by regis
Modified:
3 years, 9 months ago
Reviewers:
hausner, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make sure the signature of the call method is finalized before involving it in bound checkings of its owner class (fixes #29025). Add regression test and mark as failing for the analyzer (issue filed). Add missing trail argument in 2 locations (not related to the fixed issue). Cleanup: Remove ClassFinalizer::kCanonicalizeWellFormed which is not treated differently than ClassFinalizer::kCanonicalize anymore after earlier changes in the spec on how to handle malformed types. R=asiva@google.com, hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/063dd6d03f7941415a1e7939f3e1096314358e1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -107 lines) Patch
M runtime/lib/mirrors.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/class_finalizer.h View 2 chunks +14 lines, -12 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 18 chunks +25 lines, -21 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 7 chunks +9 lines, -14 lines 0 comments Download
M runtime/vm/object.h View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 10 chunks +54 lines, -45 lines 0 comments Download
M runtime/vm/parser.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/regress_29025_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
regis
3 years, 9 months ago (2017-03-15 18:47:00 UTC) #2
hausner
LGTM.
3 years, 9 months ago (2017-03-15 22:33:27 UTC) #3
siva
lgtm
3 years, 9 months ago (2017-03-15 22:36:40 UTC) #4
regis
3 years, 9 months ago (2017-03-15 23:44:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
063dd6d03f7941415a1e7939f3e1096314358e1a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698