Make sure the signature of the call method is finalized before involving it

runtime/vm/class_finalizer.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_VM_CLASS_FINALIZER_H_
 #define RUNTIME_VM_CLASS_FINALIZER_H_
 
 #include "vm/allocation.h"
 #include "vm/growable_array.h"
 #include "vm/object.h"
 
 namespace dart {
 
 // Traverses all pending, unfinalized classes, validates and marks them as
 // finalized.
 class ClassFinalizer : public AllStatic {
  public:
   typedef ZoneGrowableHandlePtrArray<const AbstractType> PendingTypes;
 
   // Modes for type resolution and finalization. The ordering is relevant.
   enum FinalizationKind {
     kIgnore,                 // Type is ignored and replaced by dynamic.
     kDoNotResolve,           // Type resolution is postponed.
     kResolveTypeParameters,  // Resolve type parameters only.
-    kFinalize,               // Type resolution and finalization are required.
-    kCanonicalize,           // Same as kFinalize, but with canonicalization.
-    kCanonicalizeWellFormed  // Error-free resolution, finalization, and
-                             // canonicalization are required.
+    kFinalize,               // Resolve and finalize type and type arguments.
+    kCanonicalize            // Finalize, check bounds, and canonicalize.
   };
 
   // Finalize given type while parsing class cls.
-  // Also canonicalize type if applicable.
-  static RawAbstractType* FinalizeType(const Class& cls,
-                                       const AbstractType& type,
-                                       FinalizationKind finalization,
-                                       PendingTypes* pending_types = NULL);
+  // Also canonicalize and bound check type if applicable.
+  static RawAbstractType* FinalizeType(
+      const Class& cls,
+      const AbstractType& type,
+      FinalizationKind finalization = kCanonicalize,
+      PendingTypes* pending_types = NULL);
 
   // Finalize the types in the functions's signature while parsing class cls.
-  static void FinalizeSignature(const Class& cls, const Function& function);
+  static void FinalizeSignature(const Class& cls,
+                                const Function& function,
+                                FinalizationKind finalization = kCanonicalize);
 
   // Allocate, finalize, and return a new malformed type as if it was declared
   // in class cls at the given token position.
   // If not null, prepend prev_error to the error message built from the format
   // string and its arguments.
   static RawType* NewFinalizedMalformedType(const Error& prev_error,
                                             const Script& script,
                                             TokenPosition type_pos,
                                             const char* format,
                                             ...) PRINTF_ATTRIBUTE(4, 5);
@@ skipping 101 matching lines @@
                                     PendingTypes* pending_types,
                                     TrailPtr trail);
   static void CheckRecursiveType(const Class& cls,
                                  const AbstractType& type,
                                  PendingTypes* pending_types);
   static void CheckTypeBounds(const Class& cls, const AbstractType& type);
   static void CheckTypeArgumentBounds(const Class& cls,
                                       const TypeArguments& arguments,
                                       Error* bound_error);
   static void ResolveUpperBounds(const Class& cls);
-  static void FinalizeUpperBounds(const Class& cls,
-                                  FinalizationKind finalization);
+  static void FinalizeUpperBounds(
+      const Class& cls,
+      FinalizationKind finalization = kCanonicalize);
   static void ResolveSignature(const Class& cls, const Function& function);
   static void ResolveAndFinalizeMemberTypes(const Class& cls);
   static void PrintClassInformation(const Class& cls);
   static void CollectInterfaces(const Class& cls,
                                 GrowableArray<const Class*>* collected);
 
   static void MarkTypeMalformed(const Error& prev_error,
                                 const Script& script,
                                 const Type& type,
                                 const char* format,
@@ skipping 10 matching lines @@
                            ...) PRINTF_ATTRIBUTE(4, 5);
 
   // Verify implicit offsets recorded in the VM for direct access to fields of
   // Dart instances (e.g: _TypedListView, _ByteDataView).
   static void VerifyImplicitFieldOffsets();
 };
 
 }  // namespace dart
 
 #endif  // RUNTIME_VM_CLASS_FINALIZER_H_