Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2755663002: Move files in wtf/ to platform/wtf/ (Part 2). (Closed)

Created:
3 years, 9 months ago by Yuta Kitamura
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, kinuko+watch, blink-reviews-wtf_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move files in wtf/ to platform/wtf/ (Part 2). Still moving files with few dependencies. AddressSanitizer.h Alignment.h AutoReset.h BitwiseOperations.h CheckedNumeric.h ConditionalDestructor.h ContainerAnnotations.h CurrentTime.{h,cpp} DynamicAnnotations.{h,cpp} GetPtr.h LeakAnnotations.h Noncopyable.h BUG=691465 Review-Url: https://codereview.chromium.org/2755663002 Cr-Commit-Position: refs/heads/master@{#457336} Committed: https://chromium.googlesource.com/chromium/src/+/4f82080b17ca6763d7c578826bf70b40a926dc17

Patch Set 1 #

Patch Set 2 : Fix file name (facepalm). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -846 lines) Patch
A + third_party/WebKit/Source/platform/wtf/AddressSanitizer.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/Alignment.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/AutoReset.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/BitwiseOperations.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/CheckedNumeric.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/ConditionalDestructor.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/ContainerAnnotations.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/CurrentTime.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/CurrentTime.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/DynamicAnnotations.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/DynamicAnnotations.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/GetPtr.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/LeakAnnotations.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/Noncopyable.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/wtf/AddressSanitizer.h View 1 chunk +5 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/wtf/Alignment.h View 1 chunk +7 lines, -92 lines 0 comments Download
M third_party/WebKit/Source/wtf/AutoReset.h View 1 chunk +7 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/wtf/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/BitwiseOperations.h View 1 chunk +7 lines, -50 lines 0 comments Download
M third_party/WebKit/Source/wtf/CheckedNumeric.h View 1 chunk +7 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/wtf/ConditionalDestructor.h View 1 chunk +5 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/wtf/ContainerAnnotations.h View 1 chunk +5 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/wtf/CurrentTime.h View 1 chunk +7 lines, -77 lines 0 comments Download
D third_party/WebKit/Source/wtf/CurrentTime.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
M third_party/WebKit/Source/wtf/DynamicAnnotations.h View 1 chunk +7 lines, -112 lines 0 comments Download
D third_party/WebKit/Source/wtf/DynamicAnnotations.cpp View 1 chunk +0 lines, -60 lines 0 comments Download
M third_party/WebKit/Source/wtf/GetPtr.h View 1 chunk +7 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/wtf/LeakAnnotations.h View 1 chunk +7 lines, -140 lines 0 comments Download
D third_party/WebKit/Source/wtf/Noncopyable.h View 1 1 chunk +7 lines, -27 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (13 generated)
Yuta Kitamura
This is the 2nd round. PTAL?
3 years, 9 months ago (2017-03-15 09:23:35 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-03-15 09:25:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755663002/20001
3 years, 9 months ago (2017-03-16 03:12:53 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 03:22:09 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4f82080b17ca6763d7c578826bf7...

Powered by Google App Engine
This is Rietveld 408576698