Coordinators are now notified when moving to a parent coordinator.

Coordinators are now notified when moving to a parent coordinator.

BUG=none
R=rohitrao@chromium.org

Review-Url: https://codereview.chromium.org/2755653002
Cr-Commit-Position: refs/heads/master@{#457797}
Committed: https://chromium.googlesource.com/chromium/src/+/69cbe27e5f410d7ee965648b63d013703302cfdc

[lpromero, 2017-03-15 09:10:59]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 09:11:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 09:25:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 09:25:10]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-03-15 12:07:47]

lgtm

[rohitrao (ping after 24h), 2017-03-15 12:09:05]

We may need a corresponding method that is called when the child is removed, but
we can hold off on adding that until we have an actual use case.

[lpromero, 2017-03-15 12:15:09]

https://codereview.chromium.org/2755653002/diff/1/ios/clean/chrome/browser/br...
File ios/clean/chrome/browser/browser_coordinator+internal.h (right):

https://codereview.chromium.org/2755653002/diff/1/ios/clean/chrome/browser/br...
ios/clean/chrome/browser/browser_coordinator+internal.h:61: -
(void)coordinatorDidMoveToParentCoordinator;
Note that I don't pass the parentCoordinator anymore. The receiver can ask for
its parentCoordinator directly.

[edchin, 2017-03-15 17:46:17]

edchin@chromium.org changed reviewers:
+ edchin@chromium.org

[edchin, 2017-03-15 17:46:18]

lgtm.

[lpromero, 2017-03-17 16:22:34]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[lpromero, 2017-03-17 16:22:39]

The CQ bit was checked by lpromero@chromium.org

[lpromero, 2017-03-17 16:22:39]

The patchset sent to the CQ was uploaded after l-g-t-m from edchin@chromium.org,
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2755653002/#ps20001
(title: "Pass the parent coordinator as parameter.")

[commit-bot: I haz the power, 2017-03-17 16:22:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 16:50:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489767759540680,
"parent_rev": "0485e8ec0ab7d527744dcd61328b7f23a1eecfda", "commit_rev":
"69cbe27e5f410d7ee965648b63d013703302cfdc"}

[commit-bot: I haz the power, 2017-03-17 16:51:16]

Description was changed from

==========
Coordinators are now notified when moving to a parent coordinator.

BUG=none
R=rohitrao@chromium.org
==========

to

==========
Coordinators are now notified when moving to a parent coordinator.

BUG=none
R=rohitrao@chromium.org

Review-Url: https://codereview.chromium.org/2755653002
Cr-Commit-Position: refs/heads/master@{#457797}
Committed:
https://chromium.googlesource.com/chromium/src/+/69cbe27e5f410d7ee965648b63d0...
==========

[commit-bot: I haz the power, 2017-03-17 16:51:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/69cbe27e5f410d7ee965648b63d0...