chrome/browser/resources/settings/internet_page/internet_known_networks_page.html - Issue 2755643006: MD Settings: Network a11y fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/internet_known_networks_page.html

Issue 2755643006: MD Settings: Network a11y fixes (Closed)

Patch Set: Use item.Name for known networks Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/device_page/device_page.html ('k') | chrome/browser/resources/settings/internet_page/internet_subpage.html » ('j') | ui/webui/resources/cr_elements/network/cr_network_list.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/internet_known_networks_page.html

diff --git a/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html b/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html

index 991bd7410bfb3a38a5eaf9ee5e111165c547dfdd..5650323684db46f29190ab6f6d809013354d33b5 100644

--- a/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html

+++ b/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html

@@ -31,7 +31,8 @@

<button class="subpage-arrow" is="paper-icon-button-light"

- actionable on-tap="fireShowDetails_" tabindex$="[[tabindex]]">

+ actionable on-tap="fireShowDetails_" tabindex$="[[tabindex]]"

+ aria-label$="[[getDetailsA11yString_(item)]]">

hcarmona 2017/03/17 21:58:22 I think you missed one here.

stevenjb 2017/03/17 22:54:08 Done.

</button>

<paper-icon-button preferred icon="cr:more-vert"

@@ -53,7 +54,8 @@

<button class="subpage-arrow" is="paper-icon-button-light"

- actionable on-tap="fireShowDetails_" tabindex$="[[tabindex]]">

+ actionable on-tap="fireShowDetails_" tabindex$="[[tabindex]]"

+ aria-label$="[[item.Name]]">

</button>

<paper-icon-button icon="cr:more-vert" tabindex$="[[tabindex]]"