Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Side by Side Diff: chrome/browser/resources/settings/internet_page/internet_known_networks_page.html

Issue 2755643006: MD Settings: Network a11y fixes (Closed)
Patch Set: Use item.Name for known networks Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html"> 1 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html">
2 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 2 <link rel="import" href="chrome://resources/cr_elements/icons.html">
3 <link rel="import" href="chrome://resources/html/polymer.html"> 3 <link rel="import" href="chrome://resources/html/polymer.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html">
7 <link rel="import" href="../settings_shared_css.html"> 7 <link rel="import" href="../settings_shared_css.html">
8 8
9 <dom-module id="settings-internet-known-networks-page"> 9 <dom-module id="settings-internet-known-networks-page">
10 <template> 10 <template>
(...skipping 13 matching lines...) Expand all
24 <div class="list-frame"> 24 <div class="list-frame">
25 <div class="list-item" 25 <div class="list-item"
26 hidden$="[[havePreferred_(networkStateList_)]]"> 26 hidden$="[[havePreferred_(networkStateList_)]]">
27 $i18n{internetNoNetworks} 27 $i18n{internetNoNetworks}
28 </div> 28 </div>
29 <template is="dom-repeat" items="[[networkStateList_]]" 29 <template is="dom-repeat" items="[[networkStateList_]]"
30 filter="networkIsPreferred_"> 30 filter="networkIsPreferred_">
31 <div class="list-item"> 31 <div class="list-item">
32 <div class="start">[[item.Name]]</div> 32 <div class="start">[[item.Name]]</div>
33 <button class="subpage-arrow" is="paper-icon-button-light" 33 <button class="subpage-arrow" is="paper-icon-button-light"
34 actionable on-tap="fireShowDetails_" tabindex$="[[tabindex]]"> 34 actionable on-tap="fireShowDetails_" tabindex$="[[tabindex]]"
35 aria-label$="[[getDetailsA11yString_(item)]]">
hcarmona 2017/03/17 21:58:22 I think you missed one here.
stevenjb 2017/03/17 22:54:08 Done.
35 </button> 36 </button>
36 <div class="secondary-action"> 37 <div class="secondary-action">
37 <paper-icon-button preferred icon="cr:more-vert" 38 <paper-icon-button preferred icon="cr:more-vert"
38 tabindex$="[[tabindex]]" on-tap="onMenuButtonTap_" 39 tabindex$="[[tabindex]]" on-tap="onMenuButtonTap_"
39 title="$i18n{moreActions}"> 40 title="$i18n{moreActions}">
40 </paper-icon-button> 41 </paper-icon-button>
41 </div> 42 </div>
42 </div> 43 </div>
43 </template> 44 </template>
44 </div> 45 </div>
45 46
46 <div class="settings-box"> 47 <div class="settings-box">
47 <div class="secondary">$i18n{knownNetworksAll}</div> 48 <div class="secondary">$i18n{knownNetworksAll}</div>
48 </div> 49 </div>
49 <div class="list-frame" 50 <div class="list-frame"
50 hidden$="[[!haveNotPreferred_(networkStateList_)]]"> 51 hidden$="[[!haveNotPreferred_(networkStateList_)]]">
51 <template is="dom-repeat" items="[[networkStateList_]]" 52 <template is="dom-repeat" items="[[networkStateList_]]"
52 filter="networkIsNotPreferred_"> 53 filter="networkIsNotPreferred_">
53 <div class="list-item"> 54 <div class="list-item">
54 <div class="start">[[item.Name]]</div> 55 <div class="start">[[item.Name]]</div>
55 <button class="subpage-arrow" is="paper-icon-button-light" 56 <button class="subpage-arrow" is="paper-icon-button-light"
56 actionable on-tap="fireShowDetails_" tabindex$="[[tabindex]]"> 57 actionable on-tap="fireShowDetails_" tabindex$="[[tabindex]]"
58 aria-label$="[[item.Name]]">
57 </button> 59 </button>
58 <div class="secondary-action"> 60 <div class="secondary-action">
59 <paper-icon-button icon="cr:more-vert" tabindex$="[[tabindex]]" 61 <paper-icon-button icon="cr:more-vert" tabindex$="[[tabindex]]"
60 on-tap="onMenuButtonTap_" title="$i18n{moreActions}"> 62 on-tap="onMenuButtonTap_" title="$i18n{moreActions}">
61 </paper-icon-button> 63 </paper-icon-button>
62 </div> 64 </div>
63 </div> 65 </div>
64 </template> 66 </template>
65 </div> 67 </div>
66 68
67 <dialog id="dotsMenu" is="cr-action-menu"> 69 <dialog id="dotsMenu" is="cr-action-menu">
68 <button class="dropdown-item" role="option" 70 <button class="dropdown-item" role="option"
69 hidden="[[selectedIsPreferred_]]" on-tap="onAddPreferredTap_"> 71 hidden="[[selectedIsPreferred_]]" on-tap="onAddPreferredTap_">
70 $i18n{knownNetworksMenuAddPreferred} 72 $i18n{knownNetworksMenuAddPreferred}
71 </button> 73 </button>
72 <button class="dropdown-item" role="option" 74 <button class="dropdown-item" role="option"
73 hidden="[[!selectedIsPreferred_]]" on-tap="onRemovePreferredTap_"> 75 hidden="[[!selectedIsPreferred_]]" on-tap="onRemovePreferredTap_">
74 $i18n{knownNetworksMenuRemovePreferred} 76 $i18n{knownNetworksMenuRemovePreferred}
75 </button> 77 </button>
76 <button class="dropdown-item" role="option" on-tap="onForgetTap_"> 78 <button class="dropdown-item" role="option" on-tap="onForgetTap_">
77 $i18n{knownNetworksMenuForget} 79 $i18n{knownNetworksMenuForget}
78 </button> 80 </button>
79 </dialog> 81 </dialog>
80 82
81 </template> 83 </template>
82 <script src="internet_known_networks_page.js"></script> 84 <script src="internet_known_networks_page.js"></script>
83 </dom-module> 85 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698