cros: Extract TrayBluetoothHelper from SystemTrayDelegateChromeOS

cros: Extract TrayBluetoothHelper from SystemTrayDelegateChromeOS

This is first step toward moving system tray bluetooth glue code out of
chrome browser into ash, which is needed for the eventual mojo interface
conversion for mash.

* Create TrayBluetoothHelper as part of SystemTrayDelegateChromeOS.
* Forward method calls, don't change any functionality.
* Add a browser test to make sure I'm forwarding calls correctly.
* Add a unit test for TrayBluetoothHelper.
* Clarify the name of HasDiscoverySession(), which is a weird API.

TODO:
* Eliminiate the two-stage initialization of SystemTrayDelegateChromeOS.
I didn't want to mess with initialization timing in this CL.
* Move TrayBluetoothHelper down into ash near TrayBluetooth.

BUG=660043
TEST=automated, added to chrome browser_tests and unit_tests

Review-Url: https://codereview.chromium.org/2755643005
Cr-Commit-Position: refs/heads/master@{#457690}
Committed: https://chromium.googlesource.com/chromium/src/+/7822c80225dbb6c6fe2a887c842294a74fec2962

[James Cook, 2017-03-16 22:49:02]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2017-03-16 22:49:37]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2017-03-16 22:49:38]

msw, please take a look.

rkc, just FYI, no need to review.

[commit-bot: I haz the power, 2017-03-16 22:49:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-03-17 00:11:06]

lgtm with nits

https://codereview.chromium.org/2755643005/diff/1/ash/common/system/tray/syst...
File ash/common/system/tray/system_tray_delegate.h (right):

https://codereview.chromium.org/2755643005/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray_delegate.h:39: // TODO(jamescook): Move to
TrayBluetoothHelper.
nit: cite a bug?

https://codereview.chromium.org/2755643005/diff/1/chrome/browser/ui/ash/syste...
File chrome/browser/ui/ash/system_tray_delegate_chromeos.h (right):

https://codereview.chromium.org/2755643005/diff/1/chrome/browser/ui/ash/syste...
chrome/browser/ui/ash/system_tray_delegate_chromeos.h:215: // TODO: Move into
//ash.
nit: cite a bug?

https://codereview.chromium.org/2755643005/diff/1/chrome/browser/ui/ash/syste...
File chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc
(right):

https://codereview.chromium.org/2755643005/diff/1/chrome/browser/ui/ash/syste...
chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc:123:
// TODO(jamescook): Delete this test when TrayBluetoothHelper moves to ash.
nit: cite a bug?

https://codereview.chromium.org/2755643005/diff/1/chrome/browser/ui/ash/syste...
chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc:136:
EXPECT_FALSE(delegate->GetBluetoothDiscovering());
nit: also check IsBluetoothDiscovering like below?

https://codereview.chromium.org/2755643005/diff/1/chrome/browser/ui/ash/tray_...
File chrome/browser/ui/ash/tray_bluetooth_helper.cc (right):

https://codereview.chromium.org/2755643005/diff/1/chrome/browser/ui/ash/tray_...
chrome/browser/ui/ash/tray_bluetooth_helper.cc:15: #include
"device/bluetooth/bluetooth_adapter.h"
nit: not needed; included in header

https://codereview.chromium.org/2755643005/diff/1/chrome/browser/ui/ash/tray_...
File chrome/browser/ui/ash/tray_bluetooth_helper.h (right):

https://codereview.chromium.org/2755643005/diff/1/chrome/browser/ui/ash/tray_...
chrome/browser/ui/ash/tray_bluetooth_helper.h:65: // Returns whether bluetooth
capability is available (e.g. the Chromebook has
nit: s/Chromebook/device/?

[commit-bot: I haz the power, 2017-03-17 00:48:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 00:48:36]

Dry run: This issue passed the CQ dry run.

[James Cook, 2017-03-17 04:02:57]

Thanks for the quick review.

https://codereview.chromium.org/2755643005/diff/1/ash/common/system/tray/syst...
File ash/common/system/tray/system_tray_delegate.h (right):

https://codereview.chromium.org/2755643005/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray_delegate.h:39: // TODO(jamescook): Move to
TrayBluetoothHelper.
On 2017/03/17 00:11:05, msw wrote:
> nit: cite a bug?

Done.

https://codereview.chromium.org/2755643005/diff/1/chrome/browser/ui/ash/syste...
File chrome/browser/ui/ash/system_tray_delegate_chromeos.h (right):

https://codereview.chromium.org/2755643005/diff/1/chrome/browser/ui/ash/syste...
chrome/browser/ui/ash/system_tray_delegate_chromeos.h:215: // TODO: Move into
//ash.
On 2017/03/17 00:11:05, msw wrote:
> nit: cite a bug?

Done.

https://codereview.chromium.org/2755643005/diff/1/chrome/browser/ui/ash/syste...
File chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc
(right):

https://codereview.chromium.org/2755643005/diff/1/chrome/browser/ui/ash/syste...
chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc:123:
// TODO(jamescook): Delete this test when TrayBluetoothHelper moves to ash.
On 2017/03/17 00:11:06, msw wrote:
> nit: cite a bug?

Done.

https://codereview.chromium.org/2755643005/diff/1/chrome/browser/ui/ash/syste...
chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc:136:
EXPECT_FALSE(delegate->GetBluetoothDiscovering());
On 2017/03/17 00:11:05, msw wrote:
> nit: also check IsBluetoothDiscovering like below?

Done.

https://codereview.chromium.org/2755643005/diff/1/chrome/browser/ui/ash/tray_...
File chrome/browser/ui/ash/tray_bluetooth_helper.cc (right):

https://codereview.chromium.org/2755643005/diff/1/chrome/browser/ui/ash/tray_...
chrome/browser/ui/ash/tray_bluetooth_helper.cc:15: #include
"device/bluetooth/bluetooth_adapter.h"
On 2017/03/17 00:11:06, msw wrote:
> nit: not needed; included in header

Done.

https://codereview.chromium.org/2755643005/diff/1/chrome/browser/ui/ash/tray_...
File chrome/browser/ui/ash/tray_bluetooth_helper.h (right):

https://codereview.chromium.org/2755643005/diff/1/chrome/browser/ui/ash/tray_...
chrome/browser/ui/ash/tray_bluetooth_helper.h:65: // Returns whether bluetooth
capability is available (e.g. the Chromebook has
On 2017/03/17 00:11:06, msw wrote:
> nit: s/Chromebook/device/?

Done.

[James Cook, 2017-03-17 04:03:23]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2017-03-17 04:03:24]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2755643005/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-17 04:03:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 05:09:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489723403665960,
"parent_rev": "ac41ff944457de546ad75f2a19e4d6c2c14f2af0", "commit_rev":
"7822c80225dbb6c6fe2a887c842294a74fec2962"}

[commit-bot: I haz the power, 2017-03-17 05:11:18]

Description was changed from

==========
cros: Extract TrayBluetoothHelper from SystemTrayDelegateChromeOS

This is first step toward moving system tray bluetooth glue code out of
chrome browser into ash, which is needed for the eventual mojo interface
conversion for mash.

* Create TrayBluetoothHelper as part of SystemTrayDelegateChromeOS.
* Forward method calls, don't change any functionality.
* Add a browser test to make sure I'm forwarding calls correctly.
* Add a unit test for TrayBluetoothHelper.
* Clarify the name of HasDiscoverySession(), which is a weird API.

TODO:
* Eliminiate the two-stage initialization of SystemTrayDelegateChromeOS.
I didn't want to mess with initialization timing in this CL.
* Move TrayBluetoothHelper down into ash near TrayBluetooth.

BUG=660043
TEST=automated, added to chrome browser_tests and unit_tests
==========

to

==========
cros: Extract TrayBluetoothHelper from SystemTrayDelegateChromeOS

This is first step toward moving system tray bluetooth glue code out of
chrome browser into ash, which is needed for the eventual mojo interface
conversion for mash.

* Create TrayBluetoothHelper as part of SystemTrayDelegateChromeOS.
* Forward method calls, don't change any functionality.
* Add a browser test to make sure I'm forwarding calls correctly.
* Add a unit test for TrayBluetoothHelper.
* Clarify the name of HasDiscoverySession(), which is a weird API.

TODO:
* Eliminiate the two-stage initialization of SystemTrayDelegateChromeOS.
I didn't want to mess with initialization timing in this CL.
* Move TrayBluetoothHelper down into ash near TrayBluetooth.

BUG=660043
TEST=automated, added to chrome browser_tests and unit_tests

Review-Url: https://codereview.chromium.org/2755643005
Cr-Commit-Position: refs/heads/master@{#457690}
Committed:
https://chromium.googlesource.com/chromium/src/+/7822c80225dbb6c6fe2a887c8422...
==========

[commit-bot: I haz the power, 2017-03-17 05:11:19]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7822c80225dbb6c6fe2a887c8422...