Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2755643002: Revert of Move UrlManagerTest to junit (Closed)

Created:
3 years, 9 months ago by tzik
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move UrlManagerTest to junit (patchset #4 id:60001 of https://codereview.chromium.org/2723783003/ ) Reason for revert: The tests in this CL got flaky after the move: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/39287 https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid_Tests%2F39287%2F%2B%2Frecipes%2Fsteps%2Fchrome_junit_tests%2F0%2Fsteps%2Fchrome_junit_tests%2F0%2Fstdout failures: org.chromium.chrome.browser.physicalweb.UrlManagerTest#testUpgradeFromNone org.chromium.chrome.browser.physicalweb.UrlManagerTest#testSerializationWorksWithPoorlySerializedResult java.lang.AssertionError at org.junit.Assert.fail(Assert.java:86) at org.junit.Assert.assertTrue(Assert.java:41) at org.junit.Assert.assertTrue(Assert.java:52) at org.chromium.chrome.browser.physicalweb.UrlManagerTest.testSerializationWorksWithPoorlySerializedResult(UrlManagerTest.java:291) java.lang.AssertionError at org.junit.Assert.fail(Assert.java:86) at org.junit.Assert.assertTrue(Assert.java:41) at org.junit.Assert.assertTrue(Assert.java:52) at org.chromium.chrome.browser.physicalweb.UrlManagerTest.testUpgradeFromNone(UrlManagerTest.java:361) Original issue's description: > Move UrlManagerTest to junit > > UrlManagerTest does not need to be an instrumentation test, so this > change moves it from javatests/ to junit/. > > BUG=696804 > > Review-Url: https://codereview.chromium.org/2723783003 > Cr-Commit-Position: refs/heads/master@{#456804} > Committed: https://chromium.googlesource.com/chromium/src/+/cbb4ab906568a80aa3e7a314e6570cc3b8900777 TBR=mattreynolds@chromium.org,jbudorick@chromium.org,dtrainor@chromium.org,cco3@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=696804 Review-Url: https://codereview.chromium.org/2755643002 Cr-Commit-Position: refs/heads/master@{#457030} Committed: https://chromium.googlesource.com/chromium/src/+/fa45e7d972ca1e35ffbe033a96203e5fa99bdf2d

Patch Set 1 #

Patch Set 2 : resolve conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -539 lines) Patch
M chrome/android/java_sources.gni View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/MockPwsClient.java View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java View 1 14 chunks +51 lines, -77 lines 0 comments Download
D chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/MockPwsClient.java View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java View 1 chunk +0 lines, -377 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tzik
Created Revert of Move UrlManagerTest to junit
3 years, 9 months ago (2017-03-15 07:52:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755643002/1
3 years, 9 months ago (2017-03-15 07:52:22 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/android/java_sources.gni: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-15 07:53:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755643002/140001
3 years, 9 months ago (2017-03-15 08:11:39 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 08:13:21 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/fa45e7d972ca1e35ffbe033a9620...

Powered by Google App Engine
This is Rietveld 408576698