Chromium Code Reviews
DescriptionRevert of Move UrlManagerTest to junit (patchset #4 id:60001 of https://codereview.chromium.org/2723783003/ )
Reason for revert:
The tests in this CL got flaky after the move:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/39287
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid_Tests%2F39287%2F%2B%2Frecipes%2Fsteps%2Fchrome_junit_tests%2F0%2Fsteps%2Fchrome_junit_tests%2F0%2Fstdout
failures:
org.chromium.chrome.browser.physicalweb.UrlManagerTest#testUpgradeFromNone
org.chromium.chrome.browser.physicalweb.UrlManagerTest#testSerializationWorksWithPoorlySerializedResult
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at org.chromium.chrome.browser.physicalweb.UrlManagerTest.testSerializationWorksWithPoorlySerializedResult(UrlManagerTest.java:291)
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at org.chromium.chrome.browser.physicalweb.UrlManagerTest.testUpgradeFromNone(UrlManagerTest.java:361)
Original issue's description:
> Move UrlManagerTest to junit
>
> UrlManagerTest does not need to be an instrumentation test, so this
> change moves it from javatests/ to junit/.
>
> BUG=696804
>
> Review-Url: https://codereview.chromium.org/2723783003
> Cr-Commit-Position: refs/heads/master@{#456804}
> Committed: https://chromium.googlesource.com/chromium/src/+/cbb4ab906568a80aa3e7a314e6570cc3b8900777
TBR=mattreynolds@chromium.org,jbudorick@chromium.org,dtrainor@chromium.org,cco3@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=696804
Review-Url: https://codereview.chromium.org/2755643002
Cr-Commit-Position: refs/heads/master@{#457030}
Committed: https://chromium.googlesource.com/chromium/src/+/fa45e7d972ca1e35ffbe033a96203e5fa99bdf2d
Patch Set 1 #Patch Set 2 : resolve conflict #
Messages
Total messages: 10 (5 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||