[Refactor] Update template files for callback functions

Refactoring of template files for callback functions
- Fix invalid format (put a space after ::create())
- Fix an indentation
- Replace m_scriptState->isolate() with isolate
- Move the empty implementation of trace() to .h.tmpl file
- Fold static long lines.

BUG=660281
Review-Url: https://codereview.chromium.org/2755603003
Cr-Commit-Position: refs/heads/master@{#457048}
Committed: https://chromium.googlesource.com/chromium/src/+/2100813cb0c0d18a87434921433fda24d04cda16

[peria, 2017-03-15 06:59:09]

Description was changed from

==========
[Reformat] Update template files for callback functions


BUG=660281
==========

to

==========
Refactoring of template files for callback functions


BUG=660281
==========

[peria, 2017-03-15 06:59:50]

Patchset #1 (id:1) has been deleted

[peria, 2017-03-15 07:32:33]

Patchset #1 (id:20001) has been deleted

[peria, 2017-03-15 07:37:22]

Description was changed from

==========
Refactoring of template files for callback functions


BUG=660281
==========

to

==========
Refactoring of template files for callback functions
- Fix an invalid format (put a space after ::create())
- Replace m_scriptState->isolate() with isolate
- Move the empty implementation of trace() to .h.tmpl file
- Fold static long lines.


BUG=660281
==========

[peria, 2017-03-15 07:57:03]

Description was changed from

==========
Refactoring of template files for callback functions
- Fix an invalid format (put a space after ::create())
- Replace m_scriptState->isolate() with isolate
- Move the empty implementation of trace() to .h.tmpl file
- Fold static long lines.


BUG=660281
==========

to

==========
Refactoring of template files for callback functions
- Fix invalid format (put a space after ::create())
- Fix an indentation
- Replace m_scriptState->isolate() with isolate
- Move the empty implementation of trace() to .h.tmpl file
- Fold static long lines.

BUG=660281
==========

[peria, 2017-03-15 07:57:16]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 07:57:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[peria, 2017-03-15 07:58:27]

peria@chromium.org changed reviewers:
+ bashi@chromium.org, haraken@chromium.org, yukishiino@chromium.org

[peria, 2017-03-15 07:58:28]

PTL.
I think all changes are trivial.

[Yuki, 2017-03-15 08:14:46]

LGTM.

https://codereview.chromium.org/2755603003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl
(right):

https://codereview.chromium.org/2755603003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl:21: static
{{cpp_class}}* create(ScriptState*, v8::Local<v8::Value>);
nit: Do not drop |callback| because it's meanful and helpful to understand what
the second argument is.

[haraken, 2017-03-15 08:38:20]

LGTM

[peria, 2017-03-15 08:39:06]

https://codereview.chromium.org/2755603003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl
(right):

https://codereview.chromium.org/2755603003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl:21: static
{{cpp_class}}* create(ScriptState*, v8::Local<v8::Value>);
On 2017/03/15 08:14:46, Yuki wrote:
> nit: Do not drop |callback| because it's meanful and helpful to understand
what
> the second argument is.

Done.

[peria, 2017-03-15 08:39:11]

The CQ bit was checked by peria@chromium.org

[peria, 2017-03-15 08:39:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/2755603003/#ps60001
(title: "work for comments")

[commit-bot: I haz the power, 2017-03-15 08:39:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 10:28:49]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489567151159000,
"parent_rev": "0a97ad1481495d9540e99e507e3e76ebd5a824d9", "commit_rev":
"2100813cb0c0d18a87434921433fda24d04cda16"}

[commit-bot: I haz the power, 2017-03-15 10:29:33]

Description was changed from

==========
Refactoring of template files for callback functions
- Fix invalid format (put a space after ::create())
- Fix an indentation
- Replace m_scriptState->isolate() with isolate
- Move the empty implementation of trace() to .h.tmpl file
- Fold static long lines.

BUG=660281
==========

to

==========
Refactoring of template files for callback functions
- Fix invalid format (put a space after ::create())
- Fix an indentation
- Replace m_scriptState->isolate() with isolate
- Move the empty implementation of trace() to .h.tmpl file
- Fold static long lines.

BUG=660281

Review-Url: https://codereview.chromium.org/2755603003
Cr-Commit-Position: refs/heads/master@{#457048}
Committed:
https://chromium.googlesource.com/chromium/src/+/2100813cb0c0d18a87434921433f...
==========

[commit-bot: I haz the power, 2017-03-15 10:29:36]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2100813cb0c0d18a87434921433f...

[bashi, 2017-03-15 23:30:00]

lgtm