MD Settings: Fix broken numeric prefs using boolean controls

MD Settings: Fix broken numeric prefs using boolean controls

We put readOnly: true on the numeric unchecked value property. However,
this prevents the host from binding the initial value, and prevents
the functionality from working at all.

BUG=664048
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2755553002
Cr-Commit-Position: refs/heads/master@{#457130}
Committed: https://chromium.googlesource.com/chromium/src/+/7d113d193eb693c2c8d2d60e61744fe3c3e5dec5

[tommycli, 2017-03-14 23:37:01]

Description was changed from

==========
MD Settings: Fix broken numeric prefs using boolean controls

We put readOnly: true on the numeric unchecked value property. However,
this prevents the host from binding the initial value, and prevents
the functionality from working at all.

BUG=664048
==========

to

==========
MD Settings: Fix broken numeric prefs using boolean controls

We put readOnly: true on the numeric unchecked value property. However,
this prevents the host from binding the initial value, and prevents
the functionality from working at all.

BUG=664048
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2017-03-14 23:37:34]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2017-03-14 23:37:34]

dbeam: PTAL, the numeric unchecked value can't be read only.

[Dan Beam, 2017-03-15 16:27:41]

lgtm but test?

[tommycli, 2017-03-15 16:31:43]

On 2017/03/15 16:27:41, Dan Beam wrote:
> lgtm but test?

I have now updated the test to fail before the change, and pass after the
change.

[tommycli, 2017-03-15 16:31:51]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 16:32:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 17:28:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 17:28:46]

Dry run: This issue passed the CQ dry run.

[tommycli, 2017-03-15 17:29:15]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2017-03-15 17:29:15]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2755553002/#ps20001
(title: "update test")

[commit-bot: I haz the power, 2017-03-15 17:29:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 17:50:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489598955178010,
"parent_rev": "ee1185bc45243f88ca4849e881ae8cb63d33d5e4", "commit_rev":
"7d113d193eb693c2c8d2d60e61744fe3c3e5dec5"}

[tommycli, 2017-03-15 17:50:43]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2017-03-15 17:50:43]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2017-03-15 17:51:04]

Description was changed from

==========
MD Settings: Fix broken numeric prefs using boolean controls

We put readOnly: true on the numeric unchecked value property. However,
this prevents the host from binding the initial value, and prevents
the functionality from working at all.

BUG=664048
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix broken numeric prefs using boolean controls

We put readOnly: true on the numeric unchecked value property. However,
this prevents the host from binding the initial value, and prevents
the functionality from working at all.

BUG=664048
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2755553002
Cr-Commit-Position: refs/heads/master@{#457130}
Committed:
https://chromium.googlesource.com/chromium/src/+/7d113d193eb693c2c8d2d60e6174...
==========

[commit-bot: I haz the power, 2017-03-15 17:51:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7d113d193eb693c2c8d2d60e6174...