Convert NetworkChangeNotifierTest.java to JUnit4

Convert NetworkChangeNotifierTest.java to JUnit4

Move netIdNetwork and getCapabilities, which returns types that doesn't
exist in <21 SDK, to a inner helper class. JUnit4 test would crash if these
methods are part of the test class

BUG=640116
Review-Url: https://codereview.chromium.org/2755533002
Cr-Commit-Position: refs/heads/master@{#458760}
Committed: https://chromium.googlesource.com/chromium/src/+/7569715801917d9c4dd1bdc0182bd38ff3e43cae

[the real yoland, 2017-03-14 21:46:48]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 21:47:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 23:31:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 23:31:17]

Dry run: This issue passed the CQ dry run.

[the real yoland, 2017-03-15 01:01:05]

yolandyan@chromium.org changed reviewers:
+ pauljensen@chromium.org, xunjieli@chromium.org

[the real yoland, 2017-03-15 01:01:37]

Description was changed from

==========
Convert NetworkChangeNotifierTest.java to JUnit4

Move netIdNetwork and getCapabilities, which returns types that doesn't
exist in <21 SDK. JUnit4 would crash if these methods are part of
the test class

BUG=640116
==========

to

==========
Convert NetworkChangeNotifierTest.java to JUnit4

Move netIdNetwork and getCapabilities, which returns types that doesn't
exist in <21 SDK, to a inner helper class. JUnit4 test would crash if these
methods are part of the test class

BUG=640116
==========

[the real yoland, 2017-03-15 01:14:55]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 01:15:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 02:24:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 02:24:38]

Dry run: This issue passed the CQ dry run.

[pauljensen, 2017-03-15 12:10:26]

Cool, thanks for doing this!  Just one comment.

https://codereview.chromium.org/2755533002/diff/20001/net/android/javatests/s...
File net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java
(right):

https://codereview.chromium.org/2755533002/diff/20001/net/android/javatests/s...
net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java:458: }
Can we move mNetworkConstructor into NetworkChangeNotifierTestHelper and put
this code into either a static block or perhaps initialize mNetworkConstructor
with:
mNetworkConstructor =
  (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) ?
Network.class.getConstructor(Integer.TYPE) : null;

or put the initializer code into a setUp() function in
NetworkChangeNotifierTestHelper that gets called from here?

[xunjieli, 2017-03-15 14:54:10]

Description was changed from

==========
Convert NetworkChangeNotifierTest.java to JUnit4

Move netIdNetwork and getCapabilities, which returns types that doesn't
exist in <21 SDK, to a inner helper class. JUnit4 test would crash if these
methods are part of the test class

BUG=640116
==========

to

==========
Convert NetworkChangeNotifierTest.java to JUnit4

Move netIdNetwork and getCapabilities, which returns types that doesn't
exist in <21 SDK, to a inner helper class. JUnit4 test would crash if these
methods are part of the test class

BUG=640116
==========

[xunjieli, 2017-03-15 14:54:10]

xunjieli@chromium.org changed reviewers:
- xunjieli@chromium.org

[xunjieli, 2017-03-15 14:55:02]

Moving myself to cc, since Paul is on this :)

[the real yoland, 2017-03-20 20:48:35]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 20:49:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[the real yoland, 2017-03-20 21:00:40]

https://codereview.chromium.org/2755533002/diff/20001/net/android/javatests/s...
File net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java
(right):

https://codereview.chromium.org/2755533002/diff/20001/net/android/javatests/s...
net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java:458: }
On 2017/03/15 at 12:10:26, pauljensen wrote:
> Can we move mNetworkConstructor into NetworkChangeNotifierTestHelper and put
this code into either a static block or perhaps initialize mNetworkConstructor
with:
> mNetworkConstructor =
>   (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) ?
Network.class.getConstructor(Integer.TYPE) : null;
> 
> or put the initializer code into a setUp() function in
NetworkChangeNotifierTestHelper that gets called from here?

I put the constructor as a static field in helper.
Done

[commit-bot: I haz the power, 2017-03-20 21:54:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 21:54:52]

Dry run: This issue passed the CQ dry run.

[pauljensen, 2017-03-21 11:27:55]

lgtm module two comments

https://codereview.chromium.org/2755533002/diff/40001/net/android/javatests/s...
File net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java
(right):

https://codereview.chromium.org/2755533002/diff/40001/net/android/javatests/s...
net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java:107:
private static class NetworkChangeNotifierTestHelper {
Can we rename this to Helper?  I don't see a need to restate the outer class's
name.

https://codereview.chromium.org/2755533002/diff/40001/net/android/javatests/s...
net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java:108:
private static Constructor<Network> sNetworkConstructor;
final

[the real yoland, 2017-03-22 04:31:14]

https://codereview.chromium.org/2755533002/diff/40001/net/android/javatests/s...
File net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java
(right):

https://codereview.chromium.org/2755533002/diff/40001/net/android/javatests/s...
net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java:107:
private static class NetworkChangeNotifierTestHelper {
On 2017/03/21 at 11:27:55, pauljensen wrote:
> Can we rename this to Helper?  I don't see a need to restate the outer class's
name.

Done

https://codereview.chromium.org/2755533002/diff/40001/net/android/javatests/s...
net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java:108:
private static Constructor<Network> sNetworkConstructor;
On 2017/03/21 at 11:27:55, pauljensen wrote:
> final

Done

[the real yoland, 2017-03-22 04:31:16]

The CQ bit was checked by yolandyan@chromium.org

[the real yoland, 2017-03-22 04:31:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
pauljensen@chromium.org
Link to the patchset: https://codereview.chromium.org/2755533002/#ps60001
(title: "address comments")

[commit-bot: I haz the power, 2017-03-22 04:31:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 07:18:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 07:18:33]

Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[the real yoland, 2017-03-22 15:36:52]

The CQ bit was checked by yolandyan@chromium.org

[commit-bot: I haz the power, 2017-03-22 15:37:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 15:44:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490197012321740,
"parent_rev": "143d45a4d37530b757f17f9c308412064c7d053e", "commit_rev":
"7569715801917d9c4dd1bdc0182bd38ff3e43cae"}

[commit-bot: I haz the power, 2017-03-22 15:45:13]

Description was changed from

==========
Convert NetworkChangeNotifierTest.java to JUnit4

Move netIdNetwork and getCapabilities, which returns types that doesn't
exist in <21 SDK, to a inner helper class. JUnit4 test would crash if these
methods are part of the test class

BUG=640116
==========

to

==========
Convert NetworkChangeNotifierTest.java to JUnit4

Move netIdNetwork and getCapabilities, which returns types that doesn't
exist in <21 SDK, to a inner helper class. JUnit4 test would crash if these
methods are part of the test class

BUG=640116

Review-Url: https://codereview.chromium.org/2755533002
Cr-Commit-Position: refs/heads/master@{#458760}
Committed:
https://chromium.googlesource.com/chromium/src/+/7569715801917d9c4dd1bdc0182b...
==========

[commit-bot: I haz the power, 2017-03-22 15:45:15]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7569715801917d9c4dd1bdc0182b...