Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2755523002: MD Settings: Fix layout for Play Store 'Learn more' link (Closed)

Created:
3 years, 9 months ago by stevenjb
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix layout for Play Store 'Learn more' link Partial fix to align items in the row. BUG=698463 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2755523002 Cr-Commit-Position: refs/heads/master@{#456898} Committed: https://chromium.googlesource.com/chromium/src/+/fbde8588d4780168d7c735491469c0d6b7bc1675

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/resources/settings/android_apps_page/android_apps_page.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
stevenjb
3 years, 9 months ago (2017-03-14 21:00:12 UTC) #3
Dan Beam
hmmmm, how does this fix the issue? can you send me a screenshot? the bug ...
3 years, 9 months ago (2017-03-14 21:52:11 UTC) #5
stevenjb
On 2017/03/14 21:52:11, Dan Beam wrote: > hmmmm, how does this fix the issue? can ...
3 years, 9 months ago (2017-03-14 22:09:12 UTC) #6
stevenjb
On 2017/03/14 22:09:12, stevenjb wrote: > On 2017/03/14 21:52:11, Dan Beam wrote: > > hmmmm, ...
3 years, 9 months ago (2017-03-14 22:12:22 UTC) #8
Dan Beam
lgtm
3 years, 9 months ago (2017-03-14 22:13:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755523002/20001
3 years, 9 months ago (2017-03-14 22:18:52 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 23:55:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fbde8588d4780168d7c735491469...

Powered by Google App Engine
This is Rietveld 408576698